Skip to content

Patch Release v6.1.1

Compare
Choose a tag to compare
@ruck314 ruck314 released this 21 Sep 00:51
· 204 commits to main since this release
64ac9ce

Pull Requests Since v6.1.0

Bug

  1. #973 - Add warning when loading a configuration and variable mode is not enabled

Enhancement

  1. #972 - Add threshold to rate test
  2. #974 - Update workflow to avoid deprecated set-output command
  3. #973 - Add warning when loading a configuration and variable mode is not enabled

Unlabeled

  1. #971 - Fix LocalVariable numpy array compare

Pull Request Details

Fix LocalVariable numpy array compare

Author: Benjamin Reese [email protected]
Date: Tue Sep 19 13:05:27 2023 -0700
Pull: #971 (82 additions, 60 deletions, 5 files changed)
Branch: slaclab/ben-bug-fixes
Issues: #971

Notes:

Description

Fix the compare of numpy arrays when LocalVariable.set() is called.

Also fix a bug in the Packetizer debug logging where SOF was being reported with a 7-bit shift.

Finally, fix some code formatting for readability.

Details

At some point, numpy changed the != operator to be an element-wise compare rather an an array compare. This change makes the correct numpy API calls to compare the new array against the old.


Add threshold to rate test

Author: Ryan Herbst [email protected]
Date: Wed Sep 20 17:25:06 2023 -0700
Pull: #972 (43 additions, 14 deletions, 2 files changed)
Branch: slaclab/ESROGUE-538
Issues: #972
Jira: https://jira.slac.stanford.edu/issues/ESROGUE-538
Labels: enhancement

Notes:

This PR applies a threshold to the test_rate python script. This can be used to determine if changes have significant impact on the variable access rates.


Add warning when loading a configuration and variable mode is not enabled

Author: Ryan Herbst [email protected]
Date: Wed Sep 20 17:25:32 2023 -0700
Pull: #973 (5 additions, 0 deletions, 2 files changed)
Branch: slaclab/ESROGUE-641
Issues: #973
Jira: https://jira.slac.stanford.edu/issues/ESROGUE-641
Labels: bug, enhancement

Notes:

By default loading a configuration does not apply to WO variables. Instead of failing silently this PR will generate a warning message when an entry exists in the configuration file, but will not be used because the variable has a mode which is not enabled for the configuration load.

This also fixes a bug found in the display value for the DataReceiver.


Update workflow to avoid deprecated set-output command

Author: Ryan Herbst [email protected]
Date: Wed Sep 20 12:41:32 2023 -0700
Pull: #974 (4 additions, 5 deletions, 1 files changed)
Branch: slaclab/ESROGUE-638
Issues: #974
Jira: https://jira.slac.stanford.edu/issues/ESROGUE-638
Labels: enhancement

Notes:

This replaces the set-output command with the recommend fix from github. We will not know if this works until the next release generation.