-
-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup more (?:)
from patterns
#196
Merged
slevithan
merged 9 commits into
slevithan:master
from
josephfrazier:strip-more-useless-groups
Jan 22, 2018
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
3827487
Cleanup more `(?:)` from patterns
josephfrazier 1bf6c98
Don't insert `(?:)` at beginning of (negated) lookahead
josephfrazier 2bdd982
Use nativ.test instead of RegExp#match in getContextualTokenSeparator
josephfrazier fcd54db
Test not adding (?:) at beginning of non-capturing group in middle of…
josephfrazier 75c8402
Don't add (?:) at beginning of non-capturing group in middle of pattern
josephfrazier fd9940b
Add comment explaining String#substr with negative index
josephfrazier ee766c2
Check string indices directly to determine if they're outside the string
josephfrazier 814a3f4
Add blank lines for readability
josephfrazier 222eda9
Simplify comparison
josephfrazier File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -238,6 +238,14 @@ function getContextualTokenSeparator(match, scope, flags) { | |
// No need to separate tokens if at the beginning or end of a group | ||
match.input[match.index - 1] === '(' || | ||
match.input[match.index + match[0].length] === ')' || | ||
// No need to separate tokens if at the beginning of a non-capturing group | ||
match.input.slice(match.index - 3, 3) === '(?:' || | ||
// No need to separate tokens if before or after a `|` | ||
match.input[match.index - 1] === '|' || | ||
match.input[match.index + match[0].length] === '|' || | ||
// No need to separate tokens if at the beginning or end of the pattern | ||
match.input[match.index - 1] === undefined || | ||
match.input[match.index + match[0].length] === undefined || | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ditto. Should probably be comparing to the length of There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also fixed in ee766c2 |
||
// Avoid separating tokens when the following token is a quantifier | ||
isQuantifierNext(match.input, match.index + match[0].length, flags) | ||
) { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you just check the value of
match.index - 1
directly, without involvingmatch.input
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, fixed in ee766c2 and 222eda9