Added parameter to not use the Julia worker pool #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a simple test in that checks the setter and the default are correct. https://github.com/slimgroup/JUDI.jl/blob/master/test/test_basics.jl Looks goood |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #200 +/- ##
==========================================
- Coverage 83.78% 83.78% -0.01%
==========================================
Files 28 28
Lines 2436 2442 +6
==========================================
+ Hits 2041 2046 +5
- Misses 395 396 +1
☔ View full report in Codecov by Sentry. |
mloubout
reviewed
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, JUDI uses all workers in the current pool. This MR allows the user to specify to run serially even when there is a worker pool.