Add ca-certificates to Dockerfile.hsm #1823
Open
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addition is necessary if you want to run the smallstep/step-ca:hsm container in linked mode. Without ca-certificates, the container is unable to verify https certificates of and connect to smallstep.com
github-actions
bot
added
the
needs triage
tashian
requested changes
May 30, 2024
| @@ -18,7 +18,8 @@ COPY --from=kms /usr/local/bin/step-kms-plugin /usr/local/bin/step-kms-plugin | |||
|
|
|||
| USER root | |||
| RUN apt-get update | |||
| RUN apt-get install -y --no-install-recommends pcscd libpcsclite1 | |||
| RUN apt-get install -y --no-install-recommends pcscd libpcsclite1 ca-certificates | |||
| RUN update-ca-certificates | |||
There was a problem hiding this comment.
Suggested change
| RUN update-ca-certificates |
There was a problem hiding this comment.
The post-install step for ca-certificates will update them, so I don't think update-ca-certificates needs to be explicitly run here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addition is necessary if you want to run the
smallstep/step-ca:hsmcontainer in linked mode. Withoutca-certificates, the container is unable to verify https certificates of and connect tosmallstep.comName of feature:
Adds
ca-certificatespackage tosmallstep/step-ca:hsmdocker image.Pain or issue this feature alleviates:
As of time of pull request, the
smallstep/step-ca:hsmdocker image cannot runstep-cain linked mode, because it cannot verify the https certificate of and connect tosmallstep.com. This change will add the typical public root CAs to the container's truststore.Why is this important to the project (if not answered above):
I want to run the container in linked mode
Is there documentation on how to use this feature? If so, where?
N/A
In what environments or workflows is this feature supported?
N/A
In what environments or workflows is this feature explicitly NOT supported (if any)?
N/A
Supporting links/other PRs/issues:
💔Thank you!