Allow GoReleaser Pro for make builds
#1231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs triage
maraino
requested changes
Jul 16, 2024
There was a problem hiding this comment.
It doesn't build using the last version of goreleaser:
➜ cli git:(carl/goreleaser-make) ✗ make build
⨯ build failed after 0s error=yaml: unmarshal errors:
line 374: field check_boxes not found in type config.PullRequest
make: *** [bin/step] Error 1
➜ cli git:(carl/goreleaser-make) ✗ goreleaser --version
____ ____ _
/ ___| ___ | _ \ ___| | ___ __ _ ___ ___ _ __
| | _ / _ \| |_) / _ \ |/ _ \/ _` / __|/ _ \ '__|
| |_| | (_) | _ < __/ | __/ (_| \__ \ __/ |
\____|\___/|_| \_\___|_|\___|\__,_|___/\___|_|
goreleaser: Deliver Go Binaries as fast and easily as possible
https://goreleaser.com
GitVersion: 2.1.0
GitCommit: 2a1bcaca534197ba122e76812d842aedf61930fe
GitTreeState: clean
BuildDate: 2024-07-13T17:21:33
BuiltBy: homebrew
GoVersion: go1.22.5
Compiler: gc
ModuleSum: unknown
Platform: darwin/amd64
maraino
requested changes
Jul 16, 2024
tashian
changed the title
make buildsmake builds
maraino
requested changes
Jul 17, 2024
maraino
previously approved these changes
Jul 22, 2024
maraino
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
make goreleaserto the Makefile, for those who want to build using GoReleaser Pro.We were going to make this the default builder, but after some discussion with @maraino it makes sense to keep a pure
gobuild environment and not include GoReleaser Pro as a dependency here. Especially to accommodate distro maintainers.This PR also documents available env vars in the Makefile.