OpenInBrowser on Android as well #1300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
the
needs triage
stefaanderoeck
force-pushed
the
stefaan/android-v0.20.0
branch
from
a535f65
to
51bf14b
Compare
hslatman
approved these changes
Oct 22, 2024
hslatman
approved these changes
Oct 22, 2024
|
Thank you, @stefaanderoeck 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name of feature:
support for OpenInBrowser on Android
Pain or issue this feature alleviates:
without this patch, doing "step ssh login" with and OIDC-provider results in:
with this patch applied, the browser is opened automatically
(behind the scenes by using xdg-open)
Why is this important to the project (if not answered above):
Is there documentation on how to use this feature? If so, where?
In what environments or workflows is this feature supported?
I tested this on "termux" on Android (which ships step-cli as one of its termux-packages).
(On termux, "xdg-open" links to "termux-open", which then calls Android's "am" (Activity Manager))
In what environments or workflows is this feature explicitly NOT supported (if any)?
Supporting links/other PRs/issues:
💔Thank you!