Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix --context being ignored in commands that rely on certificates #1301

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

hslatman
Copy link
Member

@hslatman hslatman commented Oct 28, 2024

This PR includes the changes from smallstep/certificates#2046 in the CLI. Commands that rely on code in certificates and use a --context were not aware of the right context to use at all times because step-ca and cli were not both using the new cli-utils import path.

@github-actions github-actions bot added the needs triage Waiting for discussion / prioritization by team label Oct 28, 2024
@hslatman hslatman force-pushed the herman/fix-step-context-cli-utils branch from 4f78617 to 8bd4d48 Compare October 28, 2024 10:05
@hslatman hslatman added this to the v0.27.6 milestone Oct 28, 2024
@hslatman hslatman requested a review from a team October 28, 2024 10:20
@hslatman hslatman linked an issue Oct 28, 2024 that may be closed by this pull request
@hslatman hslatman requested a review from dopey October 28, 2024 23:31
@hslatman hslatman merged commit b226259 into master Oct 29, 2024
16 checks passed
@hslatman hslatman deleted the herman/fix-step-context-cli-utils branch October 29, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Waiting for discussion / prioritization by team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Context is not honored
2 participants