Add disableSSHCAUser and disableSSHCAHost attributes to GCP provisioner #1305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs triage
... for provisioner add and update. Only works for GCP IID provisioner (for now).
dopey
force-pushed
the
max/disableSSHCA
branch
from
40779c7
to
6b13f45
Compare
maraino
requested changes
Oct 28, 2024
| @@ -100,6 +100,7 @@ IID (AWS/GCP/Azure) | |||
| [**--azure-audience**=<name>] [**--azure-subscription-id**=<id>] | |||
| [**--azure-object-id**=<id>] [**--instance-age**=<duration>] [**--iid-roots**=<file>] | |||
| [**--disable-custom-sans**] [**--disable-trust-on-first-use**] | |||
| [**--disable-ssh-ca-user**] [**--disable-ssh-ca-host**] | |||
There was a problem hiding this comment.
This flag is only supported in GCP right now. Should we split this into two usages or return an "unsupported" error if AWS or Azure is used? Returning an error makes more sense to me because we might want to add this functionality to Azure and AWS, too.
maraino
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.