Merge pull request #582 from smallstep/josh/fix-extra-capi-context-free

Remove extraneous 'CertFreeCertificateContext' in capi.
smallstep · Aug 30, 2024 · 32782fa · 32782fa
2 parents 1894555 + d2a8233
commit 32782fa
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/kms/capi/capi.go b/kms/capi/capi.go
@@ -791,7 +791,6 @@ func (k *CAPIKMS) DeleteCertificate(req *apiv1.DeleteCertificateRequest) error {
 		if certHandle == nil {
 			return nil
 		}
-		defer windows.CertFreeCertificateContext(certHandle)
 
 		if err := windows.CertDeleteCertificateFromStore(certHandle); err != nil {
 			return fmt.Errorf("failed removing certificate: %w", err)
@@ -822,7 +821,6 @@ func (k *CAPIKMS) DeleteCertificate(req *apiv1.DeleteCertificateRequest) error {
 		if certHandle == nil {
 			return nil
 		}
-		defer windows.CertFreeCertificateContext(certHandle)
 
 		if err := windows.CertDeleteCertificateFromStore(certHandle); err != nil {
 			return fmt.Errorf("failed removing certificate: %w", err)
@@ -862,10 +860,10 @@ func (k *CAPIKMS) DeleteCertificate(req *apiv1.DeleteCertificateRequest) error {
 			if certHandle == nil {
 				return nil
 			}
-			defer windows.CertFreeCertificateContext(certHandle)
 
 			x509Cert, err := certContextToX509(certHandle)
 			if err != nil {
+				defer windows.CertFreeCertificateContext(certHandle)
 				return fmt.Errorf("could not unmarshal certificate to DER: %w", err)
 			}