Add disableSSHCAUser and disableSSHCAHost options to GCP provisioner #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopey
force-pushed
the
max/disableSSHCA_GCP
branch
from
6c1ca46
to
51065ee
Compare
maraino
requested changes
Oct 26, 2024
spec/linkedca/provisioners.proto
Outdated
Comment on lines
120
to
121
| optional bool disableSSHCAUser = 6; | ||
| optional bool disableSSHCAHost = 7; |
There was a problem hiding this comment.
Names should be camel_case. The indentation also looks different.
maraino
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.