Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth params #84

Merged
merged 3 commits into from
Jun 12, 2024
Merged

Auth params #84

merged 3 commits into from
Jun 12, 2024

Conversation

jdoupe
Copy link
Contributor

@jdoupe jdoupe commented Apr 17, 2024

Name of feature:

Adding OIDC fields in support of smallstep/certificates#1802

Pain or issue this feature alleviates:

Why is this important to the project (if not answered above):

Is there documentation on how to use this feature? If so, where?

In what environments or workflows is this feature supported?

In what environments or workflows is this feature explicitly NOT supported (if any)?

Supporting links/other PRs/issues:

certificates - smallstep/certificates#1802
cli - smallstep/cli#1154

💔Thank you!

@jdoupe jdoupe requested a review from a team as a code owner April 17, 2024 20:36
@CLAassistant
Copy link

CLAassistant commented Apr 17, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@maraino maraino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jdoupe, looks good, I will look at the other PRs next week and tag this.

@maraino
Copy link
Contributor

maraino commented Apr 19, 2024

@jdoupe Can you sign the CLA?

@jdoupe
Copy link
Contributor Author

jdoupe commented Apr 19, 2024

@maraino - Apologies. Thought that had been completed. Done! (/)

@maraino maraino merged commit 121e05b into smallstep:main Jun 12, 2024
13 checks passed
maraino added a commit that referenced this pull request Jun 12, 2024
This commit regenerates protos after merging #84
@maraino maraino mentioned this pull request Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants