Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source branches are not deleted when using batch mode #354

Open
sdclarke opened this issue Oct 26, 2022 · 4 comments · Fixed by hiboxsystems/marge-bot#37 · May be fixed by #355
Open

Source branches are not deleted when using batch mode #354

sdclarke opened this issue Oct 26, 2022 · 4 comments · Fixed by hiboxsystems/marge-bot#37 · May be fixed by #355

Comments

@sdclarke
Copy link

When using batch mode with the an MR set to delete the source branch, the branch will not be deleted as the target branch is pushed to directly by Marge Bot.
@sdclarke sdclarke linked a pull request Oct 26, 2022 that will close this issue
Open
@nanonyme
Copy link

This is not actually the worst part. In batch merge Marge also pushes to the source branches which can result in a lot of unneeded pipelines. Cleaning up needs some work.

@sdclarke
Copy link
Author

This is not actually the worst part. In batch merge Marge also pushes to the source branches which can result in a lot of unneeded pipelines. Cleaning up needs some work.

Would what you're describing be solved by using the --skip-ci-batches flag?

--skip-ci-batches     Skip CI when updating individual MRs when using batches   [env var: MARGE_SKIP_CI_BATCHES] (default: False)

@nanonyme
Copy link

Sounds indeed possible. We'll give it a try.

@xtermi2
Copy link

xtermi2 commented Jan 13, 2023

We have also experienced this issue.

@xtermi2 xtermi2 mentioned this issue Jan 13, 2023
Merged
alatiera pushed a commit to alatiera/marge-bot that referenced this issue Oct 16, 2024
@nanonyme @nejch
Remove source branches in batch jobs if necessary
7253157 
In batch jobs source branch deletion can be bypassed, despite the setting being
enabled in the original merge request. This change will check if the source
branch should be deleted and make the appropriate API call to delete if so.

Fixes smarkets#354
alatiera pushed a commit to alatiera/marge-bot that referenced this issue Oct 16, 2024
@nejch
Merge branch 'nanonyme/cleanup' into 'main'
2f48a64 
Remove source branches in batch jobs if necessary

Closes smarkets#354

See merge request marge-org/marge-bot!425
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@nanonyme @xtermi2 @sdclarke