cast changeset errors even if they have other metadata attached #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've noticed this for a while but it's not a big problem... but I think the reason why a lot of our changeset error codes get translated to `"unknown_error"` is because the keyword list in the changeset can include other properties. It would be nice to probably also send those to the frontend really -- for example, if the error is "Name is limited to 100 characters", returning the max characters in the payload is helpful for localization e.g. `"code": "max_length", "message": "Name is limited to 100 characters", "validation": { "max_length": 100 }`
note: untested, just wrote in GitHub as a proposal
Signed-off-by: Matt Miller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed this for a while but it's not a big problem... but I think the reason why a lot of our changeset error codes get translated to
"unknown_error"is because the keyword list in the changeset can include other properties. It would be nice to probably also send those to the frontend really -- for example, if the error is "Name is limited to 100 characters", returning the max characters in the payload is helpful for localization e.g."code": "max_length", "message": "Name is limited to 100 characters", "validation": { "max_length": 100 }note: untested, just wrote in GitHub editor directly as a proposal 😬