Skip to content

Commit

Permalink
[buildattr64] More review comments from MaskRay
Browse files Browse the repository at this point in the history
Make further corrections, these were all non-functional in nature.
This commit will be squashed prior to merging.
  • Loading branch information
smithp35 committed Dec 11, 2023
1 parent 2e33926 commit 2e82708
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 5 deletions.
4 changes: 3 additions & 1 deletion buildattr64/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@

## About this document

The [Build Attributes for the Arm 64-bit Architecture](buildattr64.rst) describes the
The [Build Attributes for the Arm 64-bit Architecture](buildattr64.rst)
describes the implementation of build attributes for the 64-bit
Arm Architecture.

## About the license

Expand Down
1 change: 0 additions & 1 deletion buildattr64/buildattr64.rst
Original file line number Diff line number Diff line change
Expand Up @@ -902,4 +902,3 @@ Private subsections
-------------------

The tool interface for private subsections is implementation defined.

4 changes: 1 addition & 3 deletions design-documents/buildattr64-rationale.rst
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@ attributes can have advantages when modelling properties that:
multiple feature bits with forcing functions. A concrete example is
``FEAT_LSE2`` which can only exist if ``FEAT_LSE`` exists.

- require more then one attribute to describe. For example the
- require more than one attribute to describe. For example the
(PAUTHABI64_) describes signing schema as a tuple of (vendor,
version). This would require two attributes to completely describe.

Expand Down Expand Up @@ -543,5 +543,3 @@ There are several downsides:
- Humans make textual errors, requiring validation and error handling.

- Textual formats are slower to parse and take up more space.


0 comments on commit 2e82708

Please sign in to comment.