Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added migration folder v0.5.3 #592

Merged
merged 5 commits into from
Nov 4, 2024
Merged

Added migration folder v0.5.3 #592

merged 5 commits into from
Nov 4, 2024

Conversation

andrewp-CWF
Copy link
Collaborator

Folder includes join_tracking_table_crossings_view.sql and migrate.sh

Pull request also includes additional wcrp column in wcrp_watersheds.csv

Column shows which wcrp the watershed belongs to
db.v0.5.3 includes join_tracking_table_crossings_vw.sql and migrate.sh
Added column in table creation
@smnorris
Copy link
Owner

smnorris commented Nov 1, 2024

looks good to me, have you already applied to the CWF databases?

I see the wcrp column in prod, so I'll merge and apply to the BC db.

@andrewp-CWF
Copy link
Collaborator Author

I added in the wcrp column and run the function, so the views are in the wcrp schemas

@andrewp-CWF
Copy link
Collaborator Author

Hey Simon, was this merged and applied to the BC db?

@smnorris
Copy link
Owner

smnorris commented Nov 4, 2024

No, the migration doesn't run as is. Can you make the changes?

@andrewp-CWF
Copy link
Collaborator Author

I can make the changes,

It seems to be failing when it tries to load the wcrp_watersheds.csv into the testing database with the extra columns. Where would I be able to alter that table? I don't think I have access to bcfishpass_test

@smnorris
Copy link
Owner

smnorris commented Nov 4, 2024

I can run the script when ready.
Add the alter statement to either migrate.sh or join_tracking_table_crossings_vw.sql, remove the change from db/v0.5.0/sql/tables/wcrp.sql and I'll run.
Thanks Andrew.

- Added statement to add the wcrp column to bcfishpass.wcrp_watersheds
- removed the change from db/v0.5.0/sql/tables/wcrp.sql
@andrewp-CWF
Copy link
Collaborator Author

Sounds good, I have just pushed the changes to the branch

@smnorris smnorris merged commit fd63568 into main Nov 4, 2024
2 checks passed
smnorris added a commit that referenced this pull request Nov 14, 2024
* main: (22 commits)
  add s3 creds to monthly workflow for dra upload
  add missing variable to monthly download workflow
  fix #496 (#595)
  Elk crossing update 2024-11-05 (#594)
  Added migration folder v0.5.3 (#592)
  CARR-Update-2024-11-04 (#593)
  QUES-Update-2024-11-01 (#591)
  more description clarification
  clearer intro of feature type/connectivity params
  fix #588
  STUL_STUR_MIDR_TAKL_UTRE_LTRE_modelled_fix (#586)
  fix #584
  swap CH/CO descriptions, fix #582
  fix #583, include CH in MIDR/TAKL watershed groups as per CWF direction
  BULK-Updates-Habitat-2024-10-23 (#581)
  BULK-Updates-2024-10-23 (#580)
  Fixed spelling error and missing variable assignment in auto_rank.py (#579)
  Additions for Tuzist'ol T'ah WCRP (#578)
  write modelled crossings cache and fptwg output to object storage, re… (#574)
  HORS_2024-10-08 (#577)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants