Specify MSRV #63
Merged
Specify MSRV #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't require any other changes and is consistent with the other smol-rs projects.
We keep it the same as that of `smol`, in hopes of being reexported from it. With clippy now part of the CI, it will check if we break MSRV.
notgull
requested changes
Jun 9, 2024
As I wrote in the commit/PR description:
|
|
Anything else? For MSRV, as I wrote on the Matrix channel, I don't feel we need a separate full check but I'm more than happy to take a PR for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We keep it the same as that of
smol, in hopes of being reexported from it.With clippy now part of the CI, it will check if we break MSRV.