use Mutex instead of RwLock for securing the inner data
#67
Conversation
There was a problem hiding this comment.
Thanks! LGTM but could you please add a brief rationale in the PR and commit description (git commit --amend && git push -f YOUR_REPO ues_mutex_instead_of_rwlock in case you didn't know how to edit commits) ? While you do that, please also append Fixes #42. to the commit message too?
The use of `RwLock` is typically used when there is a need for multiple readers and infrequent writers, as `RwLock` allows multiple concurrent readers or a single writer. However, most functions were using the `write()` method, while the `read()` method was rarely used. Fixes smol-rs#42
hozan23
force-pushed
the
ues_mutex_instead_of_rwlock
branch
from
37fac1e to
6b8a513
Compare
|
@zeenix thanks, I updated the commit message. |
|
do we have some benchmarks to check that this doesn't cause sigificant performance regressions? |
No but is there a reason we'd suspect so? 🤔 |
|
@fogti In theory, it should not cause any performance regressions. #42 didn't mention any performance issues with using rwlock, but as far as I know, the only issue with rwlock is writer starvation, whereas a mutex cannot have this issue. However, I agree that we do need some benchmarks to check the performance. I will do it when I have time. |
|
@hozan23 tbh, the link to the introduction of rwlock suffices for me. |
This addresses the issue #42
The use of
RwLockis typically used when there is a need for multiple readers and infrequent writers, asRwLockallows multiple concurrent readers or a single writer. However, most functions were using thewrite()method, while theread()method was rarely used.