Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace unnecessary atomics with non-atomic operations #94

Merged
merged 2 commits into from
Feb 17, 2024
Merged

Replace unnecessary atomics with non-atomic operations #94

merged 2 commits into from
Feb 17, 2024

Conversation

james7132
Copy link
Contributor

@james7132 james7132 commented Feb 16, 2024 •
edited
Loading

There's a few atomic variables that really don't need to be, since both Ticker and Runner can be used with exclusive mutable local access.

I don't think this will result in performance improvements per se, but this should at least be more readable.

@james7132 james7132 mentioned this pull request Feb 16, 2024
Merged
notgull
notgull approved these changes Feb 17, 2024
View reviewed changes
Copy link
Member

@notgull notgull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@notgull notgull merged commit 7ffdf5b into smol-rs:master Feb 17, 2024
8 checks passed
@notgull notgull mentioned this pull request Feb 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notgull notgull notgull approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@james7132 @notgull