Merge pull request #674 from snyk/fix/add-response-error-handler

fix: add missing error handling event [ED-319]
snyk · Nov 29, 2023 · aed1605 · aed1605
2 parents 2132567 + 5b60ad9
commit aed1605
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 0 deletions.
diff --git a/lib/client/index.ts b/lib/client/index.ts
@@ -13,6 +13,15 @@ import { systemCheckHandler } from './routesHandler/systemCheckHandler';
 import { ClientOpts } from './types/client';
 import { processStartUpHooks } from './hooks/startup/processHooks';
 
+process.on('uncaughtException', (error) => {
+  logger.error(
+    { msg: error.message, stackTrace: error.stack },
+    'Uncaught exception:',
+    error.message,
+  );
+  process.exit(1);
+});
+
 export const main = async (clientOpts: ClientOpts) => {
   try {
     logger.info({ version }, 'running in client mode');

diff --git a/lib/common/http/request.ts b/lib/common/http/request.ts
@@ -178,6 +178,27 @@ export const makeStreamingRequestToDownstream = (
               `Non 2xx HTTP Code Received`,
             );
           }
+
+          response.on('error', (error) => {
+            if (retries > 0) {
+              logger.warn(
+                { msg: localRequest.url },
+                `Downstream Response failed. Retrying after 500ms...`,
+              );
+              setTimeout(() => {
+                resolve(
+                  makeStreamingRequestToDownstream(localRequest, retries - 1),
+                );
+              }, 500); // Wait for 0.5 second before retrying
+            } else {
+              logger.error(
+                { error },
+                `Error getting response from downstream. Giving up after ${MAX_RETRY} retries.`,
+              );
+              reject(error);
+            }
+          });
+
           resolve(response);
         },
       );