Rooms sponsors #66
Merged
Rooms sponsors #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for raising this PR @carlynlee ! Ill be reviewing it tonight since I havent been able to thoroughly test this yet |
Without setting rooms in the case statement (room-105 for example) the following queries would not show the speaker in the room (intended) but instead show the entire schedule as if it were the RPi sign clients when room-105 was missing in the case: http://localhost/?room=room-105&year=2024&month=3&day=16&hour=11&minute=30
Make sure topic special chars are dealt with the same way in room as they are in scroll.php
sarcasticadmin
approved these changes
Mar 10, 2024
There was a problem hiding this comment.
@carlynlee Nice work! I think that does it for #63
Ive included a few additional changes (see commentary) but I think this is all good 
| @@ -186,7 +189,7 @@ | |||
| "netknights", | |||
| "perforce", | |||
| "redhat", | |||
| "site24x7", | |||
| case 'room-101': | ||
| case 'room-103': | ||
| case 'room-104': | ||
| case 'room-105': |
There was a problem hiding this comment.
We were missing this in the index.php so when you when to http://localhost/?room=room-105&year=2024&month=3&day=16&hour=11&minute=30 the it would show the rooms signage but instead the default (full schedule) signage.
Setting this here fix it
| @@ -383,8 +397,10 @@ | |||
| $node->{'Time'} = preg_replace('/<[^>]*>/', '', $node->{'Time'}); | |||
| $node->{'Day'} = preg_replace('/<[^>]*>/', '', $node->{'Day'}); | |||
|
|
|||
| // Remove Spaces so we can use it for a CSS class | |||
| // Remove special chars in Topic from XML request so we can use it for a CSS class | |||
There was a problem hiding this comment.
figured this was best to include here, although I it wasnt clear if we are actually utilizing this like we are in scroll.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #63
more sponsors stuff