Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEM] Components override the template API instead of the generic one #4982

Merged
merged 4 commits into from
Sep 19, 2024
Merged

[FEM] Components override the template API instead of the generic one #4982

merged 4 commits into from
Sep 19, 2024

Conversation

alxbilger
Copy link
Contributor

Following the discussions about #4943, the implementations of methods and composants must override the template-specific API instead of the generic one.

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@alxbilger alxbilger added pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Sep 9, 2024
@hugtalbot hugtalbot added the pr: breaking Change possibly inducing a compilation error label Sep 10, 2024
@alxbilger
Copy link
Contributor Author

[ci-build][with-all-tests]

@epernod epernod added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Sep 19, 2024
@epernod epernod merged commit f9ab612 into sofa-framework:master Sep 19, 2024
14 of 15 checks passed
@hugtalbot hugtalbot mentioned this pull request Sep 25, 2024
Open
@hugtalbot hugtalbot added this to the v24.12 milestone Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bakpaul bakpaul bakpaul approved these changes

@epernod epernod epernod approved these changes

@hugtalbot hugtalbot hugtalbot approved these changes

Assignees
No one assigned
Labels
pr: breaking Change possibly inducing a compilation error pr: clean Cleaning the code pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v24.12
Development

Successfully merging this pull request may close these issues.
4 participants
@alxbilger @hugtalbot @epernod @bakpaul