Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/create test graph #400

Merged
merged 11 commits into from
Aug 22, 2023
Merged

Feat/create test graph #400

merged 11 commits into from
Aug 22, 2023

Conversation

dydwo0740
Copy link
Member

  • 버그 수정
  • 기능 개발
  • 리팩토링
  • 문서 변경
  • 기타... 설명:

📝 설명

✨ 특이 사항

🖼️ 스크린샷 (선택 사항)

@github-actions
Copy link

github-actions bot commented Aug 22, 2023

📊 테스트 커버리지 결과

Overall Project 86.3% -0.09% 🍏
Files changed 96.92% 🍏

File Coverage
CarRepository.java 100% 🍏
OptionRepository.java 100% 🍏
CarService.java 96.05% 🍏
SubOptionIdAndPriceDto.java 89.47% -10.53% 🍏

Copy link
Collaborator

@tank3a tank3a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\n 지우시고 자체 머지하주십쇼

"on SalesHistory.history_id = HistoryModelMapper.history_id inner join Car " +
"on Car.car_id = SalesHistory.car_id inner join SubOptionData " +
"on SubOptionData.car_id = Car.car_id group by SalesHistory.history_id";
String sql = "select SalesHistory.sold_options_id, (car_default_price + sum(model_price)) as sum from Model inner join HistoryModelMapper\n" +
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\n 이 왜 들어있죠..?

@dydwo0740 dydwo0740 merged commit d43f9c6 into dev Aug 22, 2023
1 check passed
@dydwo0740 dydwo0740 deleted the feat/create-test-graph branch August 23, 2023 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BE] 차량 누적 데이터 반환 쿼리 최적화 및 테스트 코드 작성
2 participants