Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model 관련 리팩토링 진행 #423

Merged
merged 14 commits into from
Aug 24, 2023
Merged

Model 관련 리팩토링 진행 #423

merged 14 commits into from
Aug 24, 2023

Conversation

tank3a
Copy link
Collaborator

@tank3a tank3a commented Aug 23, 2023

  • 버그 수정
  • 기능 개발
  • 리팩토링
  • 문서 변경
  • 기타... 설명:

📝 설명

모델 관련 리팩도링 진행. 현재까지 진행한 부분에 noArgsConstructor를 private으로 지정하여 이외의 부분에선 builder로 하여금 생성의 역할을 가지도록 함

✨ 특이 사항

🖼️ 스크린샷 (선택 사항)

@tank3a tank3a requested a review from dydwo0740 August 23, 2023 06:32
@tank3a tank3a self-assigned this Aug 23, 2023
@tank3a tank3a marked this pull request as draft August 23, 2023 06:32
@tank3a tank3a marked this pull request as ready for review August 23, 2023 16:00
@github-actions
Copy link

github-actions bot commented Aug 23, 2023

📊 테스트 커버리지 결과

Overall Project 81.41% -0.71% 🍏
Files changed 92.97% 🍏

File Coverage
CarService.java 100% 🍏
CarRepository.java 100% 🍏
ModelService.java 100% 🍏
ModelController.java 100% 🍏
ModelRepository.java 100% 🍏
CarDefaultDto.java 89.78% 🍏
QuoteInfoDto.java 89.64% 🍏
ModelShortMappedDto.java 89.3% -10.7% 🍏
CarInfoDto.java 89.26% 🍏
ModelDefaultDto.java 89.19% 🍏
ModelDetailMappedDto.java 89.13% 🍏
CarTypeDto.java 89.04% 🍏
TrimInfoDto.java 89.04% 🍏
ModelEfficiencyDataDto.java 88.89% 🍏
ModelShortDataDto.java 87.2% 🍏
PowerTrainDataDto.java 86.84% -13.16% 🍏
QuoteController.java 50% 🍏
QuoteService.java 48.4% -4.91%
BoughtCarDto.java 0% 🍏

Copy link
Member

@dydwo0740 dydwo0740 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GOOD

@dydwo0740 dydwo0740 merged commit f39332e into dev Aug 24, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BE] Model 도메인 관련 리팩토링
2 participants