Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BE] Quote 관련 리팩토링 #436

Merged
merged 8 commits into from
Aug 24, 2023
Merged

[BE] Quote 관련 리팩토링 #436

merged 8 commits into from
Aug 24, 2023

Conversation

tank3a
Copy link
Collaborator

@tank3a tank3a commented Aug 24, 2023

  • 버그 수정
  • 기능 개발
  • 리팩토링
  • 문서 변경
  • 기타... 설명:

📝 설명

명시적이지 않은 클래스 및 변수명 변경, quote관련 리팩토링 진행, 테스트 코드 수정, 진행 중 프론트엔드 요청사항 반영

✨ 특이 사항

🖼️ 스크린샷 (선택 사항)

@tank3a tank3a requested a review from dydwo0740 August 24, 2023 02:43
@tank3a tank3a self-assigned this Aug 24, 2023
@tank3a tank3a marked this pull request as draft August 24, 2023 02:43
@github-actions
Copy link

📊 테스트 커버리지 결과

Overall Project 81.41% 🍏
File Coverage
QuoteDataDto.java 90.71% 🍏
QuoteInfoDto.java 89.64% 🍏
HistorySearchDto.java 89.39% 🍏
HistoryShortDto.java 82.89% 🍏
QuoteController.java 50% 🍏
QuoteService.java 48.4% 🍏
QuoteRepository.java 41.73% 🍏
RecommendConnector.java 1.92% 🍏
HistoryTotalModelPriceDto.java 0% 🍏
HistoryRequestDto.java 0% 🍏
BoughtCarDto.java 0% 🍏

@tank3a tank3a marked this pull request as ready for review August 24, 2023 04:32
dydwo0740
dydwo0740 approved these changes Aug 24, 2023
View reviewed changes
Copy link
Member

@dydwo0740 dydwo0740 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GOOD

@dydwo0740 dydwo0740 merged commit 874634d into dev Aug 24, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dydwo0740 dydwo0740 dydwo0740 approved these changes

Assignees

@tank3a tank3a

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BE] Quotes 관련 리팩토링
2 participants
@tank3a @dydwo0740