Merge pull request #146 from softeerbootcamp4th/feature/145-fix-draw

[fix] 추첨 이벤트 결과 당첨자 1명만 조회되던 버그 수정 (#145)
softeerbootcamp4th · Aug 23, 2024 · de7622d · de7622d
2 parents dd75b82 + 8bb4d39
commit de7622d
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/...ain/java/hyundai/softeer/orange/event/draw/repository/DrawEventWinningInfoRepository.java b/...ain/java/hyundai/softeer/orange/event/draw/repository/DrawEventWinningInfoRepository.java
@@ -8,5 +8,5 @@
 
 public interface DrawEventWinningInfoRepository extends JpaRepository<DrawEventWinningInfo, Long>, CustomDrawEventWinningInfoRepository {
     @EntityGraph(attributePaths = {"eventUser"})
-    List<DrawEventWinningInfo> findAllById(Long id);
+    List<DrawEventWinningInfo> findAllByDrawEventId(Long eventId);
 }
diff --git a/src/main/java/hyundai/softeer/orange/event/draw/service/DrawEventService.java b/src/main/java/hyundai/softeer/orange/event/draw/service/DrawEventService.java
@@ -78,7 +78,7 @@ public List<ResponseDrawWinnerDto> getDrawEventWinner(String drawEventId) {
         if(drawEvent == null) throw new DrawEventException(ErrorCode.EVENT_NOT_FOUND);
 
         // 당첨자 목록 반환
-        return deWinningInfoRepository.findAllById(drawEvent.getId())
+        return deWinningInfoRepository.findAllByDrawEventId(drawEvent.getId())
                 .stream()
                 .map(ResponseDrawWinnerDto::new)
                 .toList();

diff --git a/src/test/java/hyundai/softeer/orange/event/draw/service/DrawEventServiceTest.java b/src/test/java/hyundai/softeer/orange/event/draw/service/DrawEventServiceTest.java
@@ -199,15 +199,15 @@ void getDrawEventWinner() {
         var eventMetadata = createEventMetadata(eventId, EventType.draw, Instant.now());
         eventMetadata.updateDrawEvent(drawEvent);
         when(emRepository.findFirstByEventId(eventId)).thenReturn(Optional.of(eventMetadata));
-        when(deWinningInfoRepository.findAllById(drawEvent.getId())).thenReturn(List.of(DrawEventWinningInfo.of(1L, drawEvent, eventUser)));
+        when(deWinningInfoRepository.findAllByDrawEventId(drawEvent.getId())).thenReturn(List.of(DrawEventWinningInfo.of(1L, drawEvent, eventUser)));
 
         // when
         var result = deService.getDrawEventWinner(eventId);
 
         // then
         assertThat(result).isNotEmpty();
         verify(emRepository, times(1)).findFirstByEventId(eventId);
-        verify(deWinningInfoRepository, times(1)).findAllById(drawEvent.getId());
+        verify(deWinningInfoRepository, times(1)).findAllByDrawEventId(drawEvent.getId());
     }
 
     @DisplayName("getDrawEventStatus: 대응되는 이벤트가 존재하지 않으면 예외 반환")