[fix] 선착순 이벤트 코드 수정 (#41) #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
win-luck
commented
Aug 8, 2024
Comment on lines
+33
to
+36
| // 이벤트 종료 여부 확인 | ||
| if (isEventEnded(eventSequence)) { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
모든 구현방안이 항상 이벤트 종료 Flag를 확인한 뒤 시작하도록 통일했습니다.
단, RedisSetFcfsService의 경우 isEventFull() 메서드 내부에 isEventEnded() 메서드를 한번 더 배치하여 여러 스레드가 접근했을 때 동시성 이슈를 발생시키지 않고 종료할 수 있도록 설정했습니다. 만약 없다면 간헐적으로(5번에 1번 꼴로) 동시성 이슈가 발생하게 됩니다.
Comment on lines
+80
to
+82
| private boolean isParticipated(Long eventSequence, String userId){ | ||
| return Boolean.TRUE.equals(stringRedisTemplate.opsForSet().isMember(FcfsUtil.participantFormatting(eventSequence.toString()), userId)); | ||
| } |
There was a problem hiding this comment.
isEventEnded(), endEvent() 외에도 "참여" 여부를 별도로 판정하기 위해 isParticipated()를 두었습니다.
Comment on lines
+80
to
82
| private boolean isEventEnded(Long eventSequence) { | ||
| return Boolean.TRUE.equals(booleanRedisTemplate.opsForValue().get(FcfsUtil.endFlagFormatting(eventSequence.toString()))); | ||
| } |
There was a problem hiding this comment.
fcfsId를 바로 key에 넣는 것을 초반에 시도했었는데 이것이 수정되지 않은 것을 확인하여 모두 고쳤습니다.
blaxsior
reviewed
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관 이슈
📝 작업 내용
참고 이미지 및 자료
Team AwesomeOrange 선착순 이벤트 구현방안 및 성능 보고서
💬 리뷰 요구사항