fix: role needs permissions to deployment list

softonic · Nov 23, 2020 · a187b25 · a187b25
1 parent ed48e1a
commit a187b25
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 17 deletions.
diff --git a/api/v1alpha1/ratelimit_types.go b/api/v1alpha1/ratelimit_types.go
@@ -86,15 +86,6 @@ type Rate struct {
 // EDIT THIS FILE!  THIS IS SCAFFOLDING FOR YOU TO OWN!
 // NOTE: json tags are required.  Any new fields you add must have json tags for the fields to be serialized.
 
-// RateLimitSpec defines the desired state of RateLimit
-/*type RateLimitSpec struct {
-	// INSERT ADDITIONAL SPEC FIELDS - desired state of cluster
-	// Important: Run "make" to regenerate code after modifying this file
-	TargetRef        v1.ObjectReference `json:"targetRef"`
-	Dimensions       DimensionsList     `json:"dimensions"`
-	WorkloadSelector map[string]string  `json:"workloadselector"`
-}
-*/
 type RateLimitSpec struct {
 	// INSERT ADDITIONAL SPEC FIELDS - desired state of cluster
 	// Important: Run "make" to regenerate code after modifying this file

diff --git a/config/crd/bases/networking.softonic.io_ratelimits.yaml b/config/crd/bases/networking.softonic.io_ratelimits.yaml
@@ -34,12 +34,6 @@ spec:
           metadata:
             type: object
           spec:
-            description: "RateLimitSpec defines the desired state of RateLimit type
-              RateLimitSpec struct { \t// INSERT ADDITIONAL SPEC FIELDS - desired
-              state of cluster \t// Important: Run \"make\" to regenerate code after
-              modifying this file \tTargetRef        v1.ObjectReference `json:\"targetRef\"`
-              \tDimensions       DimensionsList     `json:\"dimensions\"` \tWorkloadSelector
-              map[string]string  `json:\"workloadselector\"` }"
             properties:
               destinationCluster:
                 type: string

diff --git a/config/rbac/role.yaml b/config/rbac/role.yaml
@@ -30,6 +30,18 @@ rules:
   - patch
   - update
   - watch
+- apiGroups:
+  - apps
+  resources:
+  - deployments
+  verbs:
+  - create
+  - delete
+  - get
+  - list
+  - patch
+  - update
+  - watch
 - apiGroups:
   - batch
   resources:

diff --git a/controllers/envoyfilterobject.go b/controllers/envoyfilterobject.go
@@ -25,11 +25,10 @@ type EnvoyFilterObject struct {
 
 func (r *RateLimitReconciler) prepareUpdateEnvoyFilterObjects(rateLimitInstance networkingv1alpha1.RateLimit, baseName string, controllerNamespace string) error {
 
-	// controllerNamespace := os.Getenv("ISTIO_NAMESPACE")
-
 
 	istioNamespace := os.Getenv("ISTIO_NAMESPACE")
 
+
 	jsonActions := retrieveJsonActions(rateLimitInstance, baseName)
 
 	namespace := rateLimitInstance.Spec.TargetRef.Namespace

diff --git a/controllers/ratelimit_controller.go b/controllers/ratelimit_controller.go
@@ -60,6 +60,7 @@ type K8sObject struct {
 // +kubebuilder:rbac:groups=batch,resources=envoyfilters/status,verbs=get
 // +kubebuilder:rbac:groups=*,resources=configmaps,verbs=get;list;watch;create;update;patch;delete
 // +kubebuilder:rbac:groups=core,resources=configmaps,verbs=get;list;watch;create;update;patch;delete
+// +kubebuilder:rbac:groups=apps,resources=deployments,verbs=get;list;watch;create;update;patch;delete
 
 func (r *RateLimitReconciler) Reconcile(req ctrl.Request) (ctrl.Result, error) {
 	_ = context.Background()