Add functions to collect executed transactions fee in details #35363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tao-stones
commented
Feb 29, 2024
| @@ -1827,6 +1853,8 @@ impl Bank { | |||
| ))), | |||
| epoch_reward_status: fields.epoch_reward_status, | |||
| transaction_processor: TransactionBatchProcessor::default(), | |||
| // collector_fee_details is not serialized to snapshot | |||
There was a problem hiding this comment.
Believe it is OK to not serialize collector_fee_details, but not yet 100% sure.
This was referenced Mar 1, 2024
|
This repository is no longer in use. Please re-open this pull request in the agave repo: https://github.com/anza-xyz/agave |
|
re-open as anza-xyz#178 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Working bank should collect executed transactions's fee in detail, separating transaction_fee (half burnt) and prio fee (100% rewarded).
Summary of Changes
CollectorFeeDetailsto bank, which is NOT (de)serializedfilter_program_errors_and_collect_fee_details()implements collecting fee_details. This function is not called yet, next PR will invoke it behind a feature gate.Fixes #