add logger function to block assests load

solidbunch · Jul 24, 2024 · 4de9077 · 4de9077
1 parent d5099d5
commit 4de9077
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/blocks/PricingTable/Block.php b/blocks/PricingTable/Block.php
@@ -30,7 +30,6 @@ class Block extends BlockAbstract
             'editor_style' => [
                 'file' => 'editor.css',
                 'dependencies' => [],
-            ]
             ],
             'style' => [
                 'file' => 'style.css',

diff --git a/src/Handlers/Blocks/BlockAbstract.php b/src/Handlers/Blocks/BlockAbstract.php
@@ -6,7 +6,9 @@
 
 use Psr\Container\ContainerExceptionInterface;
 use Psr\Container\NotFoundExceptionInterface;
+use Psr\Log\LoggerInterface;
 use RuntimeException;
+use StarterKit\App;
 use StarterKit\Handlers\Errors\ErrorHandler;
 use StarterKit\Helper\Config;
 use StarterKit\Helper\NotFoundException;
@@ -90,13 +92,16 @@ public function registerBlock(): void
      * @param string      $file
      * @param array       $data
      * @param string|null $base
+     * @param bool        $echo
      *
      * @return string
      *
+     * @throws ContainerExceptionInterface
      * @throws NotFoundException
+     * @throws NotFoundExceptionInterface
      * @throws Throwable
      */
-    public function loadBlockView(string $file = '', array $data = [], string $base = null, $echo = false): string
+    public function loadBlockView(string $file = '', array $data = [], string $base = null, bool $echo = false): string
     {
         if ($base === null) {
             $base = Config::get('blocksDir') . $this->blockName . '/' . Config::get('blocksViewDir');
@@ -215,7 +220,7 @@ public function registerBlockAssets(): void
             /**
              * Filter block asset dependencies
              */
-            $deps     = apply_filters(
+            $deps = apply_filters(
                 Config::get('hooksPrefix') . '/block_asset_dependencies',
                 $asset['dependencies'],
                 $this->blockName,
@@ -254,8 +259,9 @@ public function registerBlockAssets(): void
             }
 
             if (!in_array($type, ['editor_script', 'editor_style', 'script', 'view_script', 'style', 'view_style'])) {
-                // ToDo vvv add correct error logging
-                error_log("Unsupported asset type or context: $type");
+                /** @var LoggerInterface $logger */
+                $logger = App::container()->get(LoggerInterface::class);
+                $logger->warning("Unsupported asset type or context: $type");
             }
         }
     }