Fix failing security scan issue (#460)

* Updated issue creation logic
* Create github issue per version
* add changelog
* push fix
* Merge remote-tracking branch 'origin' into trivy-create-one-gh-issue-per-version
* remove extra printf
* Merge branch 'master' of https://github.com/solo-io/go-utils into trivy-create-one-gh-issue-per-version
* changelog

changelog/v0.21.14/security-scan-create-github-issue.yaml

@@ -0,0 +1,6 @@
+changelog:
+  - type: FIX
+    issueLink: https://github.com/solo-io/gloo/issues/5048
+    resolvesIssue: false
+    description: >
+      Fixes issue where security scanning will fail and error when scanning releases that failed mid-release.

securityscanutils/securityscan.go

@@ -170,12 +170,12 @@ func (r *SecurityScanRepo) RunMarkdownScan(ctx context.Context, client *github.C
 		if err != nil {
 			return eris.Wrapf(err, "error running image scan on image %s", imageWithRepo)
 		}
-		trivyScanMd, err := ioutil.ReadFile(output)
-		if err != nil {
-			return eris.Wrapf(err, "error reading trivy markdown scan file %s to generate github issue", output)
-		}
 
 		if vulnFound {
+			trivyScanMd, err := ioutil.ReadFile(output)
+			if err != nil {
+				return eris.Wrapf(err, "error reading trivy markdown scan file %s to generate github issue", output)
+			}
 			vulnerabilityMd += fmt.Sprintf("# %s\n\n %s\n\n", imageWithRepo, trivyScanMd)
 		}