Unset envvar subs dont overwrite with nils #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 22, 2016 10:09
If the envvar is unset, System/getenv returns a nil, which was being assoc'd in place. So you couldn't actually have a default in config, that you *optionally* override with an envvar. It'd just always be nil. This changes that so that if the envvar is unset, it won't assoc to the location; if a key did exist there it will now return.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although I didn't need this for the thing I wanted the original feature for, it occurred to me while using it that there's certainly a use case for overriding an existing default via environment, and the first implementation couldn't do that. If you didn't set the envvar, it always returned
nilfor the config coordinates, even if you had something set there in the file on disk.Also, I got to use
paredit-convolute-sexpwhile tweaking the tests, which means I am having a spectacular morning already.