Fix lldpmgrd traceback when hostname is not available #20478
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
We see below backtrace when hostname is not available during boot and lldpmgrd exits
This is because string
self.hostname
is initialized to string'None'
. It is not ofNoneType
In the code hostname which has a value of
None(NoneType)
is compared with'None'(str object)
and it fails.It then attempts to run lldpcli with hostname as
None(NoneType)
which results in traceback and exit of lldpmgrd.Work item tracking
How I did it
Initialize
self.hostname
toNone
ofNoneType
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)