Implementation of Master Arbitration. #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sallylsy
force-pushed
the
gnmi_ma_impl
branch
4 times, most recently
from
9653112
to
2c6be76
Compare
ayelrod
reviewed
Apr 26, 2023
sallylsy
force-pushed
the
gnmi_ma_impl
branch
19 times, most recently
from
6aa8241
to
70ca310
Compare
ayelrod
approved these changes
May 9, 2023
6 tasks
sachinholla
suggested changes
Jun 8, 2023
gnmi_server/server_test.go
Outdated
| } | ||
| _, err = gClient.Set(ctx, req) | ||
| if err == nil { | ||
| t.Fatal("Expected a PermissionDenied error") |
There was a problem hiding this comment.
Requests without MA extension should always pass
sachinholla
reviewed
Jun 14, 2023
sallylsy
force-pushed
the
gnmi_ma_impl
branch
13 times, most recently
from
b6facf3
to
a50214c
Compare
sachinholla
reviewed
Jul 6, 2023
sallylsy
force-pushed
the
gnmi_ma_impl
branch
6 times, most recently
from
eb7242a
to
9f98862
Compare
sachinholla
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)