SAI bfd multihop changes along with state change notifications #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yue-fred-gao
reviewed
Sep 4, 2024
| break; | ||
| } | ||
|
|
||
| bfd_info.multihop = bfd_notif->multihop; |
There was a problem hiding this comment.
Do you need port to find single hop bfd session?
There was a problem hiding this comment.
Not currently necessary because the assumption is IP addresses will be different for different ports. To make it more foolproof, we can add it later.
yue-fred-gao
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Add BFD multihop support in SONIC SAI VPP.
NOTE: This will only work when BFD multihop changes are also present in VPP codebase.
Changes
-Re-arrange existing BFD single-hop code
-Implement SAI changes to support BFD multihop session create and delete
-Add support to receive BFD notifications from VPP and propagate up to control plane so STATE_DB is updated with the latest BFD session state