[syncd] Add workaround for port error status notification #1430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add changes to handle new data types
Adding new field in port status notification is breaking change and can cause some issues when getting notification from older SAI library, this will add workaround to handle that case
|
I'm just creating this PR to see what i miss from build, i will later split this to 2 PR's as advancing SAI submodule and then commiting actual workaround |
prgeor
reviewed
Oct 10, 2024
| @@ -1300,6 +1354,52 @@ sai_status_t VendorSai::bulkRemove( | |||
| object_statuses); | |||
| } | |||
|
|
|||
| sai_status_t VendorSai::bulkRemove( | |||
There was a problem hiding this comment.
@kcudnik I see this change is not relevant as per the PR title. Can this be kept outside this PR and added in another PR?
There was a problem hiding this comment.
read this comment: #1430 (comment), this is 1st pr: #1431
prgeor
reviewed
Oct 10, 2024
| @@ -998,6 +998,60 @@ sai_status_t VendorSai::bulkCreate( | |||
| object_statuses); | |||
| } | |||
|
|
|||
| sai_status_t VendorSai::bulkCreate( | |||
There was a problem hiding this comment.
@kcudnik this change be added as another PR as this is NOT relevant as per the PR title
There was a problem hiding this comment.
read this comment: #1430 (comment), this is 1st pr: #1431
|
@kcudnik could you please check the build failure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding new field in port status notification is breaking
change and can cause some issues when getting notification
from older SAI library, this will add workaround to handle
that case