Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Unable to Build Projects with FFI Plugins in flutter-elinux #271

Merged
merged 3 commits into from
Sep 15, 2024

Conversation

Losses
Copy link
Contributor

@Losses Losses commented Sep 15, 2024

Background

Flutter has modified the way it retrieves plugins. The messageChannel plugins and ffi plugins are now retrieved and imported separately. Currently, the internal implementation of flutter-elinux has not been updated to reflect this change, resulting in build failures for plugins that depend on FFI, such as cargokit and rinf.

Solution

This PR references the official Flutter implementation to provide a fix for this issue. The changes ensure that plugins relying on FFI are correctly compiled and processed.

Important Note

I do not have any experience with C/C++, so I am unable to determine if certain modifications are appropriate. Specifically, I am referring to the changes in the following section:

Link to the specific changes

However, the fix for FFI has been locally verified and is confirmed to be correct and effective.

Changes

  • Updated the plugin retrieval mechanism to align with the latest Flutter implementation.
  • Ensured that plugins relying on FFI are correctly compiled and processed.

Please review the changes and provide feedback, especially on the C/C++ modifications.

Thank you for your attention to this matter.

FIX: #270

Copy link
Collaborator

@HidenoriMatsubayashi HidenoriMatsubayashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for sending this PR! But could you please check my comment?

lib/elinux_plugins.dart Outdated Show resolved Hide resolved
Copy link
Collaborator

@HidenoriMatsubayashi HidenoriMatsubayashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you very much!

@HidenoriMatsubayashi HidenoriMatsubayashi merged commit fdec741 into sony:main Sep 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation Request: Guidance on Flutter-elinux and Third-Party Plugin Compatibility
2 participants