Skip to content

Apply suggestions from code review #1151

Apply suggestions from code review

Apply suggestions from code review #1151

Triggered via push October 14, 2024 13:04
Status Success
Total duration 1h 6m 57s
Artifacts 20

build-test.yml

on: push
Matrix: build_and_test
Matrix: build_and_test_ubuntu_14
make_badges
0s
make_badges
Fit to window
Zoom out
Zoom in

Annotations

4 errors and 58 warnings
ubuntu-22.04: build and test (install mdns: false, use conan: true, force cpprest asio: false, dns-sd mode: multicast, enable_authorization: false)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-python@v4, lukka/[email protected], actions/[email protected]. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
ubuntu-22.04: build and test (install mdns: false, use conan: true, force cpprest asio: false, dns-sd mode: multicast, enable_authorization: true)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-python@v4, lukka/[email protected], actions/[email protected]. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
ubuntu-20.04: build and test (install mdns: false, use conan: true, force cpprest asio: false, dns-sd mode: multicast, enable_authorization: true)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-python@v4, lukka/[email protected], actions/[email protected]. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
ubuntu-20.04: build and test (install mdns: false, use conan: true, force cpprest asio: false, dns-sd mode: unicast, enable_authorization: true)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-python@v4, lukka/[email protected], actions/[email protected]. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
ubuntu-20.04: build and test (install mdns: true, use conan: true, force cpprest asio: false, dns-sd mode: multicast, enable_authorization: true)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-python@v4, lukka/[email protected], actions/[email protected]. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
ubuntu-14.04: build and test (install mdns: true, use conan: false, force cpprest asio: false, dns-sd mode: multicast, enable_authorization: true)
'nlohmann::json_abi_v3_11_3::json_pointer<RefStringType>::operator nlohmann::json_abi_v3_11_3::json_pointer<RefStringType>::string_t() const [with RefStringType = std::basic_string<char>; nlohmann::json_abi_v3_11_3::json_pointer<RefStringType>::string_t = std::basic_string<char>]' is deprecated (declared at /__w/nmos-cpp/nmos-cpp/Development/third_party/nlohmann/json.hpp:13886): Since 3.11.0; use to_string() [-Wdeprecated-declarations]
ubuntu-14.04: build and test (install mdns: true, use conan: false, force cpprest asio: false, dns-sd mode: multicast, enable_authorization: true)
'nlohmann::json_abi_v3_11_3::json_pointer<RefStringType>::operator nlohmann::json_abi_v3_11_3::json_pointer<RefStringType>::string_t() const [with RefStringType = std::basic_string<char>; nlohmann::json_abi_v3_11_3::json_pointer<RefStringType>::string_t = std::basic_string<char>]' is deprecated (declared at /__w/nmos-cpp/nmos-cpp/Development/third_party/nlohmann/json.hpp:13886): Since 3.11.0; use to_string() [-Wdeprecated-declarations]
ubuntu-14.04: build and test (install mdns: true, use conan: false, force cpprest asio: false, dns-sd mode: multicast, enable_authorization: true)
'nlohmann::json_abi_v3_11_3::json_pointer<RefStringType>::operator nlohmann::json_abi_v3_11_3::json_pointer<RefStringType>::string_t() const [with RefStringType = std::basic_string<char>; nlohmann::json_abi_v3_11_3::json_pointer<RefStringType>::string_t = std::basic_string<char>]' is deprecated (declared at /__w/nmos-cpp/nmos-cpp/Development/third_party/nlohmann/json.hpp:13886): Since 3.11.0; use to_string() [-Wdeprecated-declarations]
ubuntu-14.04: build and test (install mdns: true, use conan: false, force cpprest asio: false, dns-sd mode: multicast, enable_authorization: true)
'nlohmann::json_abi_v3_11_3::json_pointer<RefStringType>::operator nlohmann::json_abi_v3_11_3::json_pointer<RefStringType>::string_t() const [with RefStringType = std::basic_string<char>; nlohmann::json_abi_v3_11_3::json_pointer<RefStringType>::string_t = std::basic_string<char>]' is deprecated (declared at /__w/nmos-cpp/nmos-cpp/Development/third_party/nlohmann/json.hpp:13886): Since 3.11.0; use to_string() [-Wdeprecated-declarations]
ubuntu-14.04: build and test (install mdns: true, use conan: false, force cpprest asio: false, dns-sd mode: multicast, enable_authorization: true)
'nlohmann::json_abi_v3_11_3::json_pointer<RefStringType>::operator nlohmann::json_abi_v3_11_3::json_pointer<RefStringType>::string_t() const [with RefStringType = std::basic_string<char>; nlohmann::json_abi_v3_11_3::json_pointer<RefStringType>::string_t = std::basic_string<char>]' is deprecated (declared at /__w/nmos-cpp/nmos-cpp/Development/third_party/nlohmann/json.hpp:13886): Since 3.11.0; use to_string() [-Wdeprecated-declarations]
ubuntu-14.04: build and test (install mdns: true, use conan: false, force cpprest asio: false, dns-sd mode: multicast, enable_authorization: true)
'nlohmann::json_abi_v3_11_3::json_pointer<RefStringType>::operator nlohmann::json_abi_v3_11_3::json_pointer<RefStringType>::string_t() const [with RefStringType = std::basic_string<char>; nlohmann::json_abi_v3_11_3::json_pointer<RefStringType>::string_t = std::basic_string<char>]' is deprecated (declared at /__w/nmos-cpp/nmos-cpp/Development/third_party/nlohmann/json.hpp:13886): Since 3.11.0; use to_string() [-Wdeprecated-declarations]
macos-12: build and test (install mdns: false, use conan: true, force cpprest asio: false, dns-sd mode: multicast, enable_authorization: true)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-python@v4, lukka/[email protected], actions/[email protected]. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
macos-12: build and test (install mdns: false, use conan: true, force cpprest asio: false, dns-sd mode: multicast, enable_authorization: true)
You are using macOS 12. We (and Apple) do not provide support for this old version. It is expected behaviour that some formulae will fail to build in this old version. It is expected behaviour that Homebrew will be buggy and slow. Do not create any issues about this on Homebrew's GitHub repositories. Do not create any issues even if you think this message is unrelated. Any opened issues will be immediately closed without response. Do not ask for help from Homebrew or its maintainers on social media. You may ask for help in Homebrew's discussions but are unlikely to receive a response. Try to figure out the problem yourself and submit a fix as a pull request. We will review it but may or may not accept it.
windows-2022: build and test (install mdns: false, use conan: true, force cpprest asio: true, dns-sd mode: multicast, enable_authorization: false)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-python@v4, lukka/[email protected], actions/[email protected]. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
windows-2022: build and test (install mdns: false, use conan: true, force cpprest asio: true, dns-sd mode: multicast, enable_authorization: false): Development/nmos/control_protocol_methods.cpp#L33
nonstandard extension used: 'argument': conversion from 'slog::detail::`anonymous-namespace'::log<slog::base_gate,20>' to 'slog::log_statement &'
windows-2022: build and test (install mdns: false, use conan: true, force cpprest asio: true, dns-sd mode: multicast, enable_authorization: false): Development/nmos/control_protocol_methods.cpp#L88
nonstandard extension used: 'argument': conversion from 'slog::detail::`anonymous-namespace'::log<slog::base_gate,20>' to 'slog::log_statement &'
windows-2022: build and test (install mdns: false, use conan: true, force cpprest asio: true, dns-sd mode: multicast, enable_authorization: false): Development/nmos/control_protocol_methods.cpp#L96
nonstandard extension used: 'argument': conversion from 'slog::detail::`anonymous-namespace'::log<slog::base_gate,20>' to 'slog::log_statement &'
windows-2022: build and test (install mdns: false, use conan: true, force cpprest asio: true, dns-sd mode: multicast, enable_authorization: false): Development/nmos/control_protocol_methods.cpp#L132
nonstandard extension used: 'argument': conversion from 'slog::detail::`anonymous-namespace'::log<slog::base_gate,20>' to 'slog::log_statement &'
windows-2022: build and test (install mdns: false, use conan: true, force cpprest asio: true, dns-sd mode: multicast, enable_authorization: false): Development/nmos/control_protocol_methods.cpp#L139
nonstandard extension used: 'argument': conversion from 'slog::detail::`anonymous-namespace'::log<slog::base_gate,20>' to 'slog::log_statement &'
windows-2022: build and test (install mdns: false, use conan: true, force cpprest asio: true, dns-sd mode: multicast, enable_authorization: false): Development/nmos/control_protocol_methods.cpp#L171
nonstandard extension used: 'argument': conversion from 'slog::detail::`anonymous-namespace'::log<slog::base_gate,20>' to 'slog::log_statement &'
windows-2022: build and test (install mdns: false, use conan: true, force cpprest asio: true, dns-sd mode: multicast, enable_authorization: false): Development/nmos/control_protocol_methods.cpp#L201
nonstandard extension used: 'argument': conversion from 'slog::detail::`anonymous-namespace'::log<slog::base_gate,20>' to 'slog::log_statement &'
windows-2022: build and test (install mdns: false, use conan: true, force cpprest asio: true, dns-sd mode: multicast, enable_authorization: false): Development/nmos/control_protocol_methods.cpp#L209
nonstandard extension used: 'argument': conversion from 'slog::detail::`anonymous-namespace'::log<slog::base_gate,20>' to 'slog::log_statement &'
windows-2022: build and test (install mdns: false, use conan: true, force cpprest asio: true, dns-sd mode: multicast, enable_authorization: false): Development/nmos/control_protocol_methods.cpp#L216
nonstandard extension used: 'argument': conversion from 'slog::detail::`anonymous-namespace'::log<slog::base_gate,20>' to 'slog::log_statement &'
windows-2022: build and test (install mdns: false, use conan: true, force cpprest asio: true, dns-sd mode: multicast, enable_authorization: false): Development/nmos/control_protocol_methods.cpp#L280
nonstandard extension used: 'argument': conversion from 'slog::detail::`anonymous-namespace'::log<slog::base_gate,20>' to 'slog::log_statement &'
windows-2019: build and test (install mdns: false, use conan: true, force cpprest asio: false, dns-sd mode: multicast, enable_authorization: true)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-python@v4, lukka/[email protected], actions/[email protected]. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
windows-2019: build and test (install mdns: false, use conan: true, force cpprest asio: false, dns-sd mode: multicast, enable_authorization: true): Development/nmos/control_protocol_methods.cpp#L33
nonstandard extension used: 'argument': conversion from 'slog::detail::`anonymous-namespace'::log<slog::base_gate,20>' to 'slog::log_statement &'
windows-2019: build and test (install mdns: false, use conan: true, force cpprest asio: false, dns-sd mode: multicast, enable_authorization: true): Development/nmos/control_protocol_methods.cpp#L88
nonstandard extension used: 'argument': conversion from 'slog::detail::`anonymous-namespace'::log<slog::base_gate,20>' to 'slog::log_statement &'
windows-2019: build and test (install mdns: false, use conan: true, force cpprest asio: false, dns-sd mode: multicast, enable_authorization: true): Development/nmos/control_protocol_methods.cpp#L96
nonstandard extension used: 'argument': conversion from 'slog::detail::`anonymous-namespace'::log<slog::base_gate,20>' to 'slog::log_statement &'
windows-2019: build and test (install mdns: false, use conan: true, force cpprest asio: false, dns-sd mode: multicast, enable_authorization: true): Development/nmos/control_protocol_methods.cpp#L132
nonstandard extension used: 'argument': conversion from 'slog::detail::`anonymous-namespace'::log<slog::base_gate,20>' to 'slog::log_statement &'
windows-2019: build and test (install mdns: false, use conan: true, force cpprest asio: false, dns-sd mode: multicast, enable_authorization: true): Development/nmos/control_protocol_methods.cpp#L139
nonstandard extension used: 'argument': conversion from 'slog::detail::`anonymous-namespace'::log<slog::base_gate,20>' to 'slog::log_statement &'
windows-2019: build and test (install mdns: false, use conan: true, force cpprest asio: false, dns-sd mode: multicast, enable_authorization: true): Development/nmos/control_protocol_methods.cpp#L171
nonstandard extension used: 'argument': conversion from 'slog::detail::`anonymous-namespace'::log<slog::base_gate,20>' to 'slog::log_statement &'
windows-2019: build and test (install mdns: false, use conan: true, force cpprest asio: false, dns-sd mode: multicast, enable_authorization: true): Development/nmos/control_protocol_methods.cpp#L201
nonstandard extension used: 'argument': conversion from 'slog::detail::`anonymous-namespace'::log<slog::base_gate,20>' to 'slog::log_statement &'
windows-2019: build and test (install mdns: false, use conan: true, force cpprest asio: false, dns-sd mode: multicast, enable_authorization: true): Development/nmos/control_protocol_methods.cpp#L209
nonstandard extension used: 'argument': conversion from 'slog::detail::`anonymous-namespace'::log<slog::base_gate,20>' to 'slog::log_statement &'
windows-2019: build and test (install mdns: false, use conan: true, force cpprest asio: false, dns-sd mode: multicast, enable_authorization: true): Development/nmos/control_protocol_methods.cpp#L216
nonstandard extension used: 'argument': conversion from 'slog::detail::`anonymous-namespace'::log<slog::base_gate,20>' to 'slog::log_statement &'
windows-2019: build and test (install mdns: false, use conan: true, force cpprest asio: false, dns-sd mode: multicast, enable_authorization: true): Development/nmos/control_protocol_methods.cpp#L280
nonstandard extension used: 'argument': conversion from 'slog::detail::`anonymous-namespace'::log<slog::base_gate,20>' to 'slog::log_statement &'
windows-2022: build and test (install mdns: false, use conan: true, force cpprest asio: true, dns-sd mode: multicast, enable_authorization: true)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-python@v4, lukka/[email protected], actions/[email protected]. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
windows-2022: build and test (install mdns: false, use conan: true, force cpprest asio: true, dns-sd mode: multicast, enable_authorization: true): Development/nmos/control_protocol_methods.cpp#L33
nonstandard extension used: 'argument': conversion from 'slog::detail::`anonymous-namespace'::log<slog::base_gate,20>' to 'slog::log_statement &'
windows-2022: build and test (install mdns: false, use conan: true, force cpprest asio: true, dns-sd mode: multicast, enable_authorization: true): Development/nmos/control_protocol_methods.cpp#L88
nonstandard extension used: 'argument': conversion from 'slog::detail::`anonymous-namespace'::log<slog::base_gate,20>' to 'slog::log_statement &'
windows-2022: build and test (install mdns: false, use conan: true, force cpprest asio: true, dns-sd mode: multicast, enable_authorization: true): Development/nmos/control_protocol_methods.cpp#L96
nonstandard extension used: 'argument': conversion from 'slog::detail::`anonymous-namespace'::log<slog::base_gate,20>' to 'slog::log_statement &'
windows-2022: build and test (install mdns: false, use conan: true, force cpprest asio: true, dns-sd mode: multicast, enable_authorization: true): Development/nmos/control_protocol_methods.cpp#L132
nonstandard extension used: 'argument': conversion from 'slog::detail::`anonymous-namespace'::log<slog::base_gate,20>' to 'slog::log_statement &'
windows-2022: build and test (install mdns: false, use conan: true, force cpprest asio: true, dns-sd mode: multicast, enable_authorization: true): Development/nmos/control_protocol_methods.cpp#L139
nonstandard extension used: 'argument': conversion from 'slog::detail::`anonymous-namespace'::log<slog::base_gate,20>' to 'slog::log_statement &'
windows-2022: build and test (install mdns: false, use conan: true, force cpprest asio: true, dns-sd mode: multicast, enable_authorization: true): Development/nmos/control_protocol_methods.cpp#L171
nonstandard extension used: 'argument': conversion from 'slog::detail::`anonymous-namespace'::log<slog::base_gate,20>' to 'slog::log_statement &'
windows-2022: build and test (install mdns: false, use conan: true, force cpprest asio: true, dns-sd mode: multicast, enable_authorization: true): Development/nmos/control_protocol_methods.cpp#L201
nonstandard extension used: 'argument': conversion from 'slog::detail::`anonymous-namespace'::log<slog::base_gate,20>' to 'slog::log_statement &'
windows-2022: build and test (install mdns: false, use conan: true, force cpprest asio: true, dns-sd mode: multicast, enable_authorization: true): Development/nmos/control_protocol_methods.cpp#L209
nonstandard extension used: 'argument': conversion from 'slog::detail::`anonymous-namespace'::log<slog::base_gate,20>' to 'slog::log_statement &'
windows-2022: build and test (install mdns: false, use conan: true, force cpprest asio: true, dns-sd mode: multicast, enable_authorization: true): Development/nmos/control_protocol_methods.cpp#L216
nonstandard extension used: 'argument': conversion from 'slog::detail::`anonymous-namespace'::log<slog::base_gate,20>' to 'slog::log_statement &'
windows-2022: build and test (install mdns: false, use conan: true, force cpprest asio: true, dns-sd mode: multicast, enable_authorization: true): Development/nmos/control_protocol_methods.cpp#L280
nonstandard extension used: 'argument': conversion from 'slog::detail::`anonymous-namespace'::log<slog::base_gate,20>' to 'slog::log_statement &'
Deprecation notice: v1, v2, and v3 of the artifact actions
The following artifacts were uploaded using a version of actions/upload-artifact that is scheduled for deprecation: "macos-12_auth_badges", "macos-12_auth_results", "ubuntu-14.04_mdns_multicast_badges", "ubuntu-14.04_mdns_multicast_results", "ubuntu-20.04_avahi_multicast_auth_badges", "ubuntu-20.04_avahi_multicast_auth_results", "ubuntu-20.04_avahi_unicast_auth_badges", "ubuntu-20.04_avahi_unicast_auth_results", "ubuntu-20.04_mdns_multicast_auth_badges", "ubuntu-20.04_mdns_multicast_auth_results", "ubuntu-22.04_avahi_multicast_auth_badges", "ubuntu-22.04_avahi_multicast_auth_results", "ubuntu-22.04_avahi_multicast_noauth_badges", "ubuntu-22.04_avahi_multicast_noauth_results", "windows-2019_auth_badges", "windows-2019_auth_results", "windows-2022_asio_auth_badges", "windows-2022_asio_auth_results", "windows-2022_asio_noauth_badges", "windows-2022_asio_noauth_results". Please update your workflow to use v4 of the artifact actions. Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

Artifacts

Produced during runtime
Name Size
macos-12_auth_badges
60 Bytes
macos-12_auth_results
12.9 MB
ubuntu-14.04_mdns_multicast_badges
60 Bytes
ubuntu-14.04_mdns_multicast_results
12.9 MB
ubuntu-20.04_avahi_multicast_auth_badges
60 Bytes
ubuntu-20.04_avahi_multicast_auth_results
13.4 MB
ubuntu-20.04_avahi_unicast_auth_badges
60 Bytes
ubuntu-20.04_avahi_unicast_auth_results
13.9 MB
ubuntu-20.04_mdns_multicast_auth_badges
60 Bytes
ubuntu-20.04_mdns_multicast_auth_results
12.8 MB
ubuntu-22.04_avahi_multicast_auth_badges
60 Bytes
ubuntu-22.04_avahi_multicast_auth_results
13.9 MB
ubuntu-22.04_avahi_multicast_noauth_badges
60 Bytes
ubuntu-22.04_avahi_multicast_noauth_results
11.4 MB
windows-2019_auth_badges
60 Bytes
windows-2019_auth_results
8.97 MB
windows-2022_asio_auth_badges
60 Bytes
windows-2022_asio_auth_results
12.1 MB
windows-2022_asio_noauth_badges
60 Bytes
windows-2022_asio_noauth_results
10.1 MB