Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ubuntu 14.04 and MacOS runners in GitHub actions #401

Merged
merged 3 commits into from
Jul 26, 2024

Conversation

jonathan-r-thorpe
Copy link
Contributor

  • Allow Ubuntu-14.04 to use node16 instead of node20 to enable Ubuntu-14.04 runner to work
  • Upgrade no longer supported MacOS-11 runner to MacOS-12

Caveats:

  • The test install target for MacOS fails due to a CMake issue that needs to be resolved
  • For this reason the test install target (along with the test install log target) are currently excluded for MacOS runners

macos-11 no longer supported so upgrade to macos-12.
macos-11 no longer supported so upgrade to macos-12.
Exclude "install test" and "install test log" from macos build
Copy link
Contributor

@lo-simon lo-simon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathan-r-thorpe jonathan-r-thorpe merged commit 3105b86 into master Jul 26, 2024
22 checks passed
@jonathan-r-thorpe jonathan-r-thorpe deleted the fix-github-actions branch July 26, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants