Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make: run flake8 on specific directories #2572

Merged
merged 1 commit into from
Dec 2, 2023

Conversation

SnoopJ
Copy link
Contributor

@SnoopJ SnoopJ commented Nov 28, 2023

Description

Tin. Run the linter on only the files we are concerned with. This is slightly friendlier to developers who have throwaway scripts or a virtual environment (other than one in env/) in their repository directory.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make lint and make test)
  • I have tested the functionality of the things this change touches

@SnoopJ SnoopJ added Tweak Housekeeping Code cleanup, removal of deprecated stuff, etc. labels Nov 28, 2023
@SnoopJ SnoopJ modified the milestone: 8.0.1 Nov 28, 2023
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked a couple of times, didn't find any more declarative (in a config file somewhere) way to do this. The current state also bit me earlier this week, though, so let's accept this Good solution in lieu of a hypothetical Perfect one yet to be found.

@dgw dgw merged commit 5f860bb into sopel-irc:master Dec 2, 2023
13 checks passed
@SnoopJ SnoopJ deleted the chore/lint-specific-dirs branch December 3, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Housekeeping Code cleanup, removal of deprecated stuff, etc. Tweak
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants