-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci, contrib, dice, meta: enable testing on Python 3.13 + fix warnings #2628
Conversation
- ci: Added Python 3.13 to CI workflow - contrib: Added Python 3.13 envs to tox config - dice: removed unnecessary `count` parameter to `re.sub()` and pass `flags` as a kwarg (py3.13 deprecates these as positional args) - url: fix type-check error with `dnspython` 2.7 Get string representation of each result with `Rdata.to_text()`, which is one of the types that `ipaddress.ip_address()` accepts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do it!
If we wanted to add 3.13 free-threading support, it looks like there's a feature request for this in GHA: actions/setup-python#771 (I didn't yet test Sopel on a free-threaded build FWIW, but I can try it) |
I just finished a passing run on Python 3.13.0t (setting Passing the test suite doesn't necessarily guarantee perfect functionality at runtime, though, to be fair. |
I also see passing tests in both modes, although weirdly I did not see a faster suite with nogil |
I don't think it's that weird. Without installing a plugin like The better thing to think about a bit here is: Should we wait for a nogil build to be available in GHA? Is it worth running a second CI job for Python 3.13t when that feature is still experimental? Because if we aren't going to wait, this can just ship to |
-1 on both of those IMO, I think our manual checks are sufficient that there's nothing fundamentally wrong |
And it's easy enough to run through another PR like this later if we find a compelling reason to add nogil to the CI matrix, too. Just wanted to ask in case you had a different idea :) |
Note: Adding the |
Description
count
parameter tore.sub()
and passflags
as a kwarg(py3.13 deprecates these as positional args)
dnspython
2.7Use
Rdata.to_text()
to get each result as a string, which is one of the types thatipaddress.ip_address()
accepts.With the above changes, the only warning emitted during
pytest
runs under Python 3.13 is from SQLAlchemy, which isn't new; it's because we haven't fully migrated to their 2.0 style yet, and not related to which Python version is used.The type-check error from
dnspython
2.7 isn't strictly Python 3.13-related, but this patch wouldn't pass linting without it. That change doesn't seem like it needs its own PR (though it might need to be backported for 8.0.1; we'll see).Closes #2608.
Checklist
make qa
(runsmake lint
andmake test
)tox
job on every version listed, after updating them all to the latest patch release available inpyenv
. Maybe not necessary, but I was making sure thetox
config still worked after I edited it.