Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin mypy to 1.11.2 #2631

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Pin mypy to 1.11.2 #2631

merged 1 commit into from
Oct 14, 2024

Conversation

dgw
Copy link
Member

@dgw dgw commented Oct 14, 2024

Description

Tin. CI fails at the moment, and it would be nice if it kept working.

I have started a mypy-1.12 branch to work on the broken things. but it'll require some coordination with #2616 and #2629.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make lint and make test)
  • I have tested the functionality of the things this change touches

Separately, I have started a `mypy-1.12` branch to work on the broken
things. Meanwhile, though, we'd very much like for CI to keep working.
@dgw dgw requested a review from a team October 14, 2024 16:40
dev-requirements.txt Show resolved Hide resolved
Copy link
Contributor

@Exirel Exirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve because I understand the issue. I offered an optional suggestion, and I wouldn't mind if you didn't accept it.

dev-requirements.txt Show resolved Hide resolved
@dgw dgw enabled auto-merge October 14, 2024 16:59
dgw referenced this pull request Oct 14, 2024
find: support escaping backslash, fix double-bolding, and add basic tests
@dgw dgw merged commit c7693ca into master Oct 14, 2024
15 checks passed
@dgw dgw deleted the pin-mypy-1.11 branch October 14, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants