-
Notifications
You must be signed in to change notification settings - Fork 9
WitnessLinter does not consider different paths in a witness when checking thread information #34
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also adds additional checks on the spare thread IDs.
While this might be a reasonable thing to do in the future, for SV-COMP I think it is best to not introduce additional constraints after the tool submission deadline. Otherwise this might invalidate witnesses of tools that had no chance of reacting to this new constraint, and we would need to update the linter yet again in case people complain about that.
This PR also adds changes to the spec, which need to be coordinated with #30.
Easiest would be to just disable the check for now and later consolidate spec changes with #30.
Also feedback from @hernanponcedeleon and @tautschnig on these spec changes would be valuable, as they already discussed similar changes and their effects in https://gitlab.com/sosy-lab/sv-comp/archives-2021/-/issues/30
For now, I would recommend creating a PR that just disables the check for witness.CREATETHREAD
with a comment similar to #29 and #31. Then we can merge the rest after a consensus is reached and after the SV-COMP results are final. (If we merge the new check after this PR, it is not guaranteed that there will not be another change requested for the linter before the results are final, and then we would need to revert the additional check again.)
|
…esponding context.
…rograms with CPAchecker".
Ending lines with whitespaces is special in Markdown and causes a "newline" after rendering. However, none of those trailing whitespaces is required for this file.
deeebc0
to
bfbe837
Compare
I think the paragraph about I'm not sure I understand the following
Do we want to say that identifiers uniquely and completely identify active threads? Can we just say the following?
|
Yes, that would also match my intention. |
In #37, I update the specification for conformity with the upcoming journal paper. |
@kfriedberger Could you please review the part that @mdangl asked about? |
This PR is based on #33 and improves the documentation about the usage of thread identifiers.
It also disables the current check for thread creation.