[feat] 모델프로필 단건조회 및 생성 api 완성 #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sominyun
reviewed
Mar 5, 2024
| @Override | ||
| public ModelResponse getModel(Long modelId) { | ||
| Model model = modelRepository.findById(modelId) | ||
| .orElseThrow(() -> new RuntimeException("존재하지 않는 아이디")); |
There was a problem hiding this comment.
NotFoundExceoptioan 적용완뇨
|
|
||
| public record ModelRequest( | ||
| @NotNull String modelName, | ||
| @NotNull LocalDateTime birth, |
sominyun
approved these changes
Mar 5, 2024
lsm-del
reviewed
Mar 5, 2024
| import java.time.LocalDate; | ||
|
|
||
| public record ModelRequest( | ||
| @NotNull String modelName, |
There was a problem hiding this comment.
@NotNull 인자 값으로 message 추가하면 좋을 것 같아요
There was a problem hiding this comment.
프론트 입장에서 어떤 필드를 null 값으로 요청해서 에러가 났는지 알아야 하니깐요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗃 Issue
🔥 Task
📄 Reference
{ "modelName": "아이린", "birth": "1991-03-29T00:00:00Z", // 생년월일을 ISO 8601 형식으로 표현한 예시 "job": "가수", "info": "아이린에 대한 정보", "agency": "SM Entertainment", "aiRate": 0.95 }위의 데이터로 postman 테스트 했습ㄴ다.