-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect function.name
for aliased imports
#1484
base: master
Are you sure you want to change the base?
Changes from all commits
497d026
5541f1c
af8ece4
4d1f21d
9feb406
cb8226e
aca7039
ae9fb8d
95d75cb
2277b73
64824fc
98c4457
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -268,6 +268,7 @@ function prepareBuiltins(oldBuiltins: Map<string, any>) { | |
} | ||
} | ||
newBuiltins.set('undefined', undefined) | ||
newBuiltins.set('Object', Object) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not sure if this is the right move; what are the implications of this? Perhaps someone could verify/advise. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I see that you are updating the name property in the function object. But here, are you trying to add the name "Object" to the names of builtins that are visible from Source programs? |
||
return newBuiltins | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if there's a less hacky way to handle this...