Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a new LoopPropertiesNoAdjacentAnnotation compile step #1076

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

jviotti
Copy link
Member

@jviotti jviotti commented Aug 30, 2024

Signed-off-by: Juan Cruz Viotti [email protected]

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/gcc)

Benchmark suite Current: 7b52afe Previous: 7789be6 Ratio
JSONSchema_Validate_Draft4_Meta_1_No_Callback 6163.653173572586 ns/iter 7684.8167530219835 ns/iter 0.80
JSONSchema_Validate_Draft4_Required_Properties 3491.0172010820656 ns/iter 3448.3168521620123 ns/iter 1.01
JSONSchema_Validate_Draft4_Optional_Properties_Minimal_Match 819.8035490285007 ns/iter 821.8162443909573 ns/iter 1.00
JSONSchema_Validate_Draft4_Items_Schema 12116.70292462174 ns/iter 11951.22582302829 ns/iter 1.01
JSONSchema_Compile_Basic 388072.84193012305 ns/iter 389227.54550500284 ns/iter 1.00

This comment was automatically generated by workflow using github-action-benchmark.

@jviotti jviotti force-pushed the loop-properties-adjacent-annotation branch 3 times, most recently from e6180c1 to 5b96ed8 Compare August 30, 2024 23:37
@jviotti jviotti marked this pull request as ready for review August 30, 2024 23:38
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (macos)

Benchmark suite Current: 7b52afe Previous: 7789be6 Ratio
JSONSchema_Compile_Basic 197123.42587292523 ns/iter 206830.07481524645 ns/iter 0.95
JSONSchema_Validate_Draft4_Meta_1_No_Callback 6099.936029245597 ns/iter 7392.894571660287 ns/iter 0.83
JSONSchema_Validate_Draft4_Required_Properties 3450.036263239196 ns/iter 3654.227698522444 ns/iter 0.94
JSONSchema_Validate_Draft4_Optional_Properties_Minimal_Match 1206.259106709967 ns/iter 1306.3695505374967 ns/iter 0.92
JSONSchema_Validate_Draft4_Items_Schema 9139.998942424638 ns/iter 10439.41741670299 ns/iter 0.88

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/llvm)

Benchmark suite Current: 7b52afe Previous: 7789be6 Ratio
JSONSchema_Compile_Basic 802035.1051671291 ns/iter 386739.16954822233 ns/iter 2.07
JSONSchema_Validate_Draft4_Meta_1_No_Callback 14087.521096401266 ns/iter 7462.441005761438 ns/iter 1.89
JSONSchema_Validate_Draft4_Required_Properties 6807.355295068178 ns/iter 3274.4145738987377 ns/iter 2.08
JSONSchema_Validate_Draft4_Optional_Properties_Minimal_Match 1738.5921429597681 ns/iter 777.0137173085205 ns/iter 2.24
JSONSchema_Validate_Draft4_Items_Schema 24568.013961419583 ns/iter 10378.975223022591 ns/iter 2.37

This comment was automatically generated by workflow using github-action-benchmark.

@jviotti jviotti force-pushed the loop-properties-adjacent-annotation branch from 5b96ed8 to 7b52afe Compare August 30, 2024 23:44
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (windows)

Benchmark suite Current: 7b52afe Previous: 7789be6 Ratio
JSONSchema_Compile_Basic 777076.562499955 ns/iter 784526.5625001017 ns/iter 0.99
JSONSchema_Validate_Draft4_Meta_1_No_Callback 13128.667282735927 ns/iter 15602.646892724584 ns/iter 0.84
JSONSchema_Validate_Draft4_Required_Properties 5419.186999999965 ns/iter 5337.157999999818 ns/iter 1.02
JSONSchema_Validate_Draft4_Optional_Properties_Minimal_Match 2385.761785714229 ns/iter 2289.679999999805 ns/iter 1.04
JSONSchema_Validate_Draft4_Items_Schema 26934.9182256277 ns/iter 25856.357142856723 ns/iter 1.04

This comment was automatically generated by workflow using github-action-benchmark.

@jviotti jviotti merged commit 480064e into main Aug 30, 2024
12 checks passed
@jviotti jviotti deleted the loop-properties-adjacent-annotation branch August 30, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant