Simplify resolve_target in the EvaluationContext
#1094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Juan Cruz Viotti <[email protected]>
jviotti
force-pushed
the
refactor-context
branch
from
cc3158b
to
8492dcf
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark (macos)
| Benchmark suite | Current: 8492dcf | Previous: ad4b770 | Ratio |
|---|---|---|---|
JSONSchema_Compile_Basic |
203409.17878128806 ns/iter |
209398.1300690977 ns/iter |
0.97 |
JSONSchema_Validate_Draft4_Meta_1_No_Callback |
1592.261149702016 ns/iter |
1653.0829519957508 ns/iter |
0.96 |
JSONSchema_Validate_Draft4_Required_Properties |
2426.4442730819615 ns/iter |
2497.7904689323027 ns/iter |
0.97 |
JSONSchema_Validate_Draft4_Optional_Properties_Minimal_Match |
169.20161387693284 ns/iter |
171.94955733842792 ns/iter |
0.98 |
JSONSchema_Validate_Draft4_Items_Schema |
9446.387395761523 ns/iter |
9423.979664381668 ns/iter |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark (linux/llvm)
| Benchmark suite | Current: 8492dcf | Previous: ad4b770 | Ratio |
|---|---|---|---|
JSONSchema_Compile_Basic |
401167.39152262395 ns/iter |
389373.84460592445 ns/iter |
1.03 |
JSONSchema_Validate_Draft4_Meta_1_No_Callback |
2113.296622008784 ns/iter |
2187.6304676652508 ns/iter |
0.97 |
JSONSchema_Validate_Draft4_Required_Properties |
2613.611197236295 ns/iter |
2636.7671367063244 ns/iter |
0.99 |
JSONSchema_Validate_Draft4_Optional_Properties_Minimal_Match |
198.17946972879608 ns/iter |
203.32117947667922 ns/iter |
0.97 |
JSONSchema_Validate_Draft4_Items_Schema |
9985.356787360499 ns/iter |
10805.287072979008 ns/iter |
0.92 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark (linux/gcc)
| Benchmark suite | Current: 8492dcf | Previous: ad4b770 | Ratio |
|---|---|---|---|
JSONSchema_Validate_Draft4_Meta_1_No_Callback |
2170.580035652824 ns/iter |
2375.34838911163 ns/iter |
0.91 |
JSONSchema_Validate_Draft4_Required_Properties |
2785.794078153487 ns/iter |
2747.1143802741303 ns/iter |
1.01 |
JSONSchema_Validate_Draft4_Optional_Properties_Minimal_Match |
203.6273706421197 ns/iter |
218.28921658633715 ns/iter |
0.93 |
JSONSchema_Validate_Draft4_Items_Schema |
11835.78588338743 ns/iter |
12041.355921630693 ns/iter |
0.98 |
JSONSchema_Compile_Basic |
386947.28482798714 ns/iter |
387116.83573010314 ns/iter |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark (windows)
| Benchmark suite | Current: 8492dcf | Previous: ad4b770 | Ratio |
|---|---|---|---|
JSONSchema_Compile_Basic |
792840.6250000211 ns/iter |
780069.5312499987 ns/iter |
1.02 |
JSONSchema_Validate_Draft4_Meta_1_No_Callback |
4742.544514608813 ns/iter |
4741.559265421493 ns/iter |
1.00 |
JSONSchema_Validate_Draft4_Required_Properties |
3812.6713169641034 ns/iter |
3734.5620811396707 ns/iter |
1.02 |
JSONSchema_Validate_Draft4_Optional_Properties_Minimal_Match |
772.7494419642917 ns/iter |
750.5143973214651 ns/iter |
1.03 |
JSONSchema_Validate_Draft4_Items_Schema |
24308.878571430014 ns/iter |
24013.081327222473 ns/iter |
1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juan Cruz Viotti [email protected]