Compile out assertions that would never run anyway #1099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Juan Cruz Viotti <[email protected]>
jviotti
force-pushed
the
impossible-type-assertions
branch
from
9e0e571
to
d2cfc25
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark (macos)
| Benchmark suite | Current: d2cfc25 | Previous: b29de65 | Ratio |
|---|---|---|---|
JSONSchema_Compile_Basic |
196918.2077308039 ns/iter |
204049.65753429395 ns/iter |
0.97 |
JSONSchema_Validate_Draft4_Meta_1_No_Callback |
1606.859773199492 ns/iter |
1599.5496768072023 ns/iter |
1.00 |
JSONSchema_Validate_Draft4_Required_Properties |
2395.498357870798 ns/iter |
2401.6238914099445 ns/iter |
1.00 |
JSONSchema_Validate_Draft4_Optional_Properties_Minimal_Match |
167.17768345687884 ns/iter |
165.32197851504478 ns/iter |
1.01 |
JSONSchema_Validate_Draft4_Items_Schema |
9088.450663087695 ns/iter |
8964.991558762851 ns/iter |
1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark (linux/llvm)
| Benchmark suite | Current: d2cfc25 | Previous: b29de65 | Ratio |
|---|---|---|---|
JSONSchema_Compile_Basic |
396216.75084937195 ns/iter |
391864.60775620455 ns/iter |
1.01 |
JSONSchema_Validate_Draft4_Meta_1_No_Callback |
16654.83669645464 ns/iter |
16650.35405617414 ns/iter |
1.00 |
JSONSchema_Validate_Draft4_Required_Properties |
8183.919376224563 ns/iter |
8208.450116630971 ns/iter |
1.00 |
JSONSchema_Validate_Draft4_Optional_Properties_Minimal_Match |
1572.4884692315559 ns/iter |
1563.5008376216072 ns/iter |
1.01 |
JSONSchema_Validate_Draft4_Items_Schema |
105409.17920985755 ns/iter |
109444.21641678351 ns/iter |
0.96 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark (linux/gcc)
| Benchmark suite | Current: d2cfc25 | Previous: b29de65 | Ratio |
|---|---|---|---|
JSONSchema_Validate_Draft4_Meta_1_No_Callback |
2198.8636934553 ns/iter |
2285.514874075199 ns/iter |
0.96 |
JSONSchema_Validate_Draft4_Required_Properties |
2744.6906085371575 ns/iter |
2846.202824670392 ns/iter |
0.96 |
JSONSchema_Validate_Draft4_Optional_Properties_Minimal_Match |
205.14976737143937 ns/iter |
212.87328586916013 ns/iter |
0.96 |
JSONSchema_Validate_Draft4_Items_Schema |
11876.08085733133 ns/iter |
11551.45066766161 ns/iter |
1.03 |
JSONSchema_Compile_Basic |
385607.1988950376 ns/iter |
386650.7541436813 ns/iter |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark (windows)
| Benchmark suite | Current: d2cfc25 | Previous: b29de65 | Ratio |
|---|---|---|---|
JSONSchema_Compile_Basic |
801974.2187500409 ns/iter |
787890.9598212199 ns/iter |
1.02 |
JSONSchema_Validate_Draft4_Meta_1_No_Callback |
4689.305357142563 ns/iter |
4647.183832524478 ns/iter |
1.01 |
JSONSchema_Validate_Draft4_Required_Properties |
3985.6635044647046 ns/iter |
3760.838284216279 ns/iter |
1.06 |
JSONSchema_Validate_Draft4_Optional_Properties_Minimal_Match |
772.943749999858 ns/iter |
780.9710937500824 ns/iter |
0.99 |
JSONSchema_Validate_Draft4_Items_Schema |
25129.442857137616 ns/iter |
26074.427958865337 ns/iter |
0.96 |
This comment was automatically generated by workflow using github-action-benchmark.
jviotti
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juan Cruz Viotti [email protected]