Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the idea of explicit conditions from the compiler #1100

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

jviotti
Copy link
Member

@jviotti jviotti commented Sep 2, 2024

Signed-off-by: Juan Cruz Viotti [email protected]

@jviotti jviotti changed the title Remove the idea of explicit conditions in the compiler Remove the idea of explicit conditions from the compiler Sep 2, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (macos)

Benchmark suite Current: ff6e845 Previous: 1abf1db Ratio
JSONSchema_Compile_Basic 202953.78627568032 ns/iter 196226.76803394748 ns/iter 1.03
JSONSchema_Validate_Draft4_Meta_1_No_Callback 1603.3545937978124 ns/iter 1594.761266570678 ns/iter 1.01
JSONSchema_Validate_Draft4_Required_Properties 2428.5621348803998 ns/iter 2446.842602561657 ns/iter 0.99
JSONSchema_Validate_Draft4_Optional_Properties_Minimal_Match 173.55104627701664 ns/iter 168.34540484314013 ns/iter 1.03
JSONSchema_Validate_Draft4_Items_Schema 9596.01532407134 ns/iter 9097.066254912957 ns/iter 1.05

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/llvm)

Benchmark suite Current: ff6e845 Previous: 1abf1db Ratio
JSONSchema_Compile_Basic 393435.18063423637 ns/iter 390770.88024619897 ns/iter 1.01
JSONSchema_Validate_Draft4_Meta_1_No_Callback 18497.78548770984 ns/iter 16712.404949005475 ns/iter 1.11
JSONSchema_Validate_Draft4_Required_Properties 7957.483833190896 ns/iter 8153.480031776332 ns/iter 0.98
JSONSchema_Validate_Draft4_Optional_Properties_Minimal_Match 1696.4851865479961 ns/iter 1565.3725641636925 ns/iter 1.08
JSONSchema_Validate_Draft4_Items_Schema 113716.61307103906 ns/iter 106439.87255347312 ns/iter 1.07

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/gcc)

Benchmark suite Current: ff6e845 Previous: 1abf1db Ratio
JSONSchema_Validate_Draft4_Meta_1_No_Callback 2185.0229565984105 ns/iter 2262.645817470263 ns/iter 0.97
JSONSchema_Validate_Draft4_Required_Properties 2806.8630184334884 ns/iter 2790.6076460504382 ns/iter 1.01
JSONSchema_Validate_Draft4_Optional_Properties_Minimal_Match 205.770006141329 ns/iter 221.70541130855193 ns/iter 0.93
JSONSchema_Validate_Draft4_Items_Schema 12200.472900704619 ns/iter 12088.773145912433 ns/iter 1.01
JSONSchema_Compile_Basic 384762.0318856745 ns/iter 381287.5500544322 ns/iter 1.01

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (windows)

Benchmark suite Current: ff6e845 Previous: 1abf1db Ratio
JSONSchema_Compile_Basic 802412.834821504 ns/iter 839142.522321217 ns/iter 0.96
JSONSchema_Validate_Draft4_Meta_1_No_Callback 4749.08760957108 ns/iter 4838.967944124349 ns/iter 0.98
JSONSchema_Validate_Draft4_Required_Properties 3776.4028992802437 ns/iter 3802.796959291389 ns/iter 0.99
JSONSchema_Validate_Draft4_Optional_Properties_Minimal_Match 775.5652901784466 ns/iter 774.106361607098 ns/iter 1.00
JSONSchema_Validate_Draft4_Items_Schema 24710.164285717645 ns/iter 24780.01071428285 ns/iter 1.00

This comment was automatically generated by workflow using github-action-benchmark.

@jviotti jviotti merged commit 2917e0c into main Sep 3, 2024
12 checks passed
@jviotti jviotti deleted the min-max-length-conditions branch September 3, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant