Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise Pointer Token templates to only configure property type #1104

Merged
merged 6 commits into from
Sep 3, 2024

Conversation

tony-go
Copy link
Contributor

@tony-go tony-go commented Sep 3, 2024

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (macos)

Benchmark suite Current: ce5fc99 Previous: d8cc649 Ratio
JSONSchema_Compile_Basic 197850.23526096172 ns/iter 206064.517541218 ns/iter 0.96
JSONSchema_Validate_Draft4_Meta_1_No_Callback 1618.6312224410535 ns/iter 1654.379508865012 ns/iter 0.98
JSONSchema_Validate_Draft4_Required_Properties 2462.5623938601884 ns/iter 2510.702984379532 ns/iter 0.98
JSONSchema_Validate_Draft4_Optional_Properties_Minimal_Match 168.35966909513368 ns/iter 163.48228290490496 ns/iter 1.03
JSONSchema_Validate_Draft4_Items_Schema 9061.13063505124 ns/iter 8954.195170948222 ns/iter 1.01

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/llvm)

Benchmark suite Current: ce5fc99 Previous: d8cc649 Ratio
JSONSchema_Compile_Basic 389170.5588398775 ns/iter 386596.845257894 ns/iter 1.01
JSONSchema_Validate_Draft4_Meta_1_No_Callback 18540.979282280805 ns/iter 18695.762025250653 ns/iter 0.99
JSONSchema_Validate_Draft4_Required_Properties 8126.670548497665 ns/iter 8209.682737378636 ns/iter 0.99
JSONSchema_Validate_Draft4_Optional_Properties_Minimal_Match 1696.2321924838284 ns/iter 1715.6960758435935 ns/iter 0.99
JSONSchema_Validate_Draft4_Items_Schema 113248.2428363267 ns/iter 115250.2659783608 ns/iter 0.98

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/gcc)

Benchmark suite Current: ce5fc99 Previous: d8cc649 Ratio
JSONSchema_Validate_Draft4_Meta_1_No_Callback 2223.601433753165 ns/iter 2320.246035980491 ns/iter 0.96
JSONSchema_Validate_Draft4_Required_Properties 2819.3793366466944 ns/iter 2783.492350277145 ns/iter 1.01
JSONSchema_Validate_Draft4_Optional_Properties_Minimal_Match 207.3991376996912 ns/iter 207.11244816836285 ns/iter 1.00
JSONSchema_Validate_Draft4_Items_Schema 11724.952106505649 ns/iter 11699.700357691534 ns/iter 1.00
JSONSchema_Compile_Basic 383797.8212719506 ns/iter 392543.07058821345 ns/iter 0.98

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (windows)

Benchmark suite Current: ce5fc99 Previous: d8cc649 Ratio
JSONSchema_Compile_Basic 807249.2637216501 ns/iter 813526.8973215354 ns/iter 0.99
JSONSchema_Validate_Draft4_Meta_1_No_Callback 4693.088600643361 ns/iter 4682.728556008897 ns/iter 1.00
JSONSchema_Validate_Draft4_Required_Properties 3710.241231711107 ns/iter 3728.717448718902 ns/iter 1.00
JSONSchema_Validate_Draft4_Optional_Properties_Minimal_Match 774.2374999999413 ns/iter 770.2417410713838 ns/iter 1.01
JSONSchema_Validate_Draft4_Items_Schema 24540.28928571818 ns/iter 24455.15714285713 ns/iter 1.00

This comment was automatically generated by workflow using github-action-benchmark.

@tony-go tony-go marked this pull request as ready for review September 3, 2024 15:50
@jviotti jviotti changed the title refactor: introduce PropertyT Revise Pointer Token templates to only configure property type Sep 3, 2024
Signed-off-by: Tony Gorez <[email protected]>
@jviotti jviotti merged commit 2adf4c3 into main Sep 3, 2024
12 checks passed
@jviotti jviotti deleted the pointer-refactor1 branch September 3, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants