Prefer vector over sets when configuring compiler steps #1112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark (macos)
| Benchmark suite | Current: bc82bd6 | Previous: 265cd2e | Ratio |
|---|---|---|---|
JSONSchema_Compile_Basic |
198343.46030380036 ns/iter |
230445.27687298539 ns/iter |
0.86 |
JSONSchema_Validate_Draft4_Meta_1_No_Callback |
1534.2777953383074 ns/iter |
1735.203608771139 ns/iter |
0.88 |
JSONSchema_Validate_Draft4_Required_Properties |
2370.1178275009484 ns/iter |
2687.1806334958183 ns/iter |
0.88 |
JSONSchema_Validate_Draft4_Optional_Properties_Minimal_Match |
172.04795582878302 ns/iter |
194.71237842250645 ns/iter |
0.88 |
JSONSchema_Validate_Draft4_Items_Schema |
8589.816493143966 ns/iter |
9369.645935345236 ns/iter |
0.92 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark (linux/llvm)
| Benchmark suite | Current: bc82bd6 | Previous: 265cd2e | Ratio |
|---|---|---|---|
JSONSchema_Compile_Basic |
385195.05992302357 ns/iter |
394117.6388261881 ns/iter |
0.98 |
JSONSchema_Validate_Draft4_Meta_1_No_Callback |
19025.97563631231 ns/iter |
18136.408265447153 ns/iter |
1.05 |
JSONSchema_Validate_Draft4_Required_Properties |
7961.026663329537 ns/iter |
8254.605651746373 ns/iter |
0.96 |
JSONSchema_Validate_Draft4_Optional_Properties_Minimal_Match |
1746.9478611359878 ns/iter |
1704.7027155341505 ns/iter |
1.02 |
JSONSchema_Validate_Draft4_Items_Schema |
113887.81306744275 ns/iter |
114540.35470085249 ns/iter |
0.99 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark (linux/gcc)
| Benchmark suite | Current: bc82bd6 | Previous: 265cd2e | Ratio |
|---|---|---|---|
JSONSchema_Validate_Draft4_Meta_1_No_Callback |
2066.2222590387614 ns/iter |
2059.487143433589 ns/iter |
1.00 |
JSONSchema_Validate_Draft4_Required_Properties |
2604.8583943445187 ns/iter |
2711.522957570305 ns/iter |
0.96 |
JSONSchema_Validate_Draft4_Optional_Properties_Minimal_Match |
202.2492564111602 ns/iter |
207.76569461600113 ns/iter |
0.97 |
JSONSchema_Validate_Draft4_Items_Schema |
10441.873456882628 ns/iter |
10418.105458983198 ns/iter |
1.00 |
JSONSchema_Compile_Basic |
386495.04123146896 ns/iter |
384746.10263446264 ns/iter |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark (windows)
| Benchmark suite | Current: bc82bd6 | Previous: 7a10acc | Ratio |
|---|---|---|---|
JSONSchema_Compile_Basic |
799397.9910713631 ns/iter |
795571.8750000277 ns/iter |
1.00 |
JSONSchema_Validate_Draft4_Meta_1_No_Callback |
4764.007285731467 ns/iter |
4766.955907996879 ns/iter |
1.00 |
JSONSchema_Validate_Draft4_Required_Properties |
3686.2985958956974 ns/iter |
3748.2811637832083 ns/iter |
0.98 |
JSONSchema_Validate_Draft4_Optional_Properties_Minimal_Match |
748.3041294642184 ns/iter |
775.8750000000448 ns/iter |
0.96 |
JSONSchema_Validate_Draft4_Items_Schema |
24087.578571425183 ns/iter |
25110.093727467123 ns/iter |
0.96 |
This comment was automatically generated by workflow using github-action-benchmark.
Signed-off-by: Juan Cruz Viotti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juan Cruz Viotti [email protected]